Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace macos image assets #1255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chkuendig
Copy link

The currently logo has some diverging low-res assets:
image

This causes a glitch when starting the app:
glitch

This MR fixes the problem by replacing the asset with the original logo from https://github.com/transmission/transmission/blob/develop/macosx/Images/Transmission.icns

I'm aware of #1045 but since there's no movement on that I think it makes sense to fix the current icon first.

@chkuendig
Copy link
Author

Not sure why this fails CI - it had the same issue with a broken lazarus installation, even before the change.Now it builds though on my machine

@PeterDaveHello
Copy link
Member

@chkuendig thanks!

Just noticed that the commit message is a little bit too long for the commit subject, do you think you can shorten it? (Just put the details in the body)

Ref: https://chris.beams.io/posts/git-commit/

@chkuendig
Copy link
Author

shortened it

@chkuendig
Copy link
Author

chkuendig commented Oct 4, 2019

Thanks for the encouragement, I encountered two separate issues though:

  • I still can't reproduce the CI failure. It builds fine for me on a Mojave System with the dependencies from the build script. I can't build a working build at all on Catalina

  • It actually seems there's one more asset affecting this, and this asset is actually part of the cross-platform transgui.ico (which uses the "frontal perspective" icon [ https://upload.wikimedia.org/wikipedia/commons/thumb/4/46/Transmission_Icon.svg/1200px-Transmission_Icon.svg.png ]). Would it make sense to keep this for all other platforms and only replace during build time (in that case I'll update the build script)? At the moment it's not really clear which should be the primary icon for transgui. I can also use the other icon (the "frontal" one) for all macOS icons.

PS: On second thought, maybe using

image
for all icons makes the most sense. Apple has also moved to much more "flatter" icons recently anyway. So I'd suggest to use this logo also for macOS unless there's any concerns. I'll update this MR in the next few days.

@PeterDaveHello
Copy link
Member

hmmm, I'll take a look when I have enough time, thanks again.

@PeterDaveHello
Copy link
Member

Sorry for the late reply, would like to see if #1045 is a go, and if so, maybe the problem here won't exist ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants