Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve BaseForm's getNativeFormProps types #1037

Closed
wadamek65 opened this issue Sep 28, 2021 · 0 comments · Fixed by #1044
Closed

Improve BaseForm's getNativeFormProps types #1037

wadamek65 opened this issue Sep 28, 2021 · 0 comments · Fixed by #1044
Assignees
@kestarumper
Labels
Type: Feature New features and feature requests
Projects
Open Source (migrated)
Milestone
v3.7

Comments

@wadamek65
Copy link
Contributor

https://github.com/vazco/uniforms/blob/master/packages/uniforms/src/BaseForm.tsx#L169

Things we could improve:

  1. Add proper types for key and onSubmit properties as these are always present.
  2. Change Record<string, any> type to Record<string, unknown> as it will be overall more type-safe.
@wadamek65 wadamek65 added the Type: Feature New features and feature requests label Sep 28, 2021
@wadamek65 wadamek65 added this to Needs triage in Open Source (migrated) via automation Sep 28, 2021
@wadamek65 wadamek65 moved this from Needs triage to To do in Open Source (migrated) Sep 28, 2021
@radekmie radekmie added this to the v3.x milestone Sep 29, 2021
@kestarumper kestarumper self-assigned this Sep 29, 2021
@kestarumper kestarumper moved this from To do to In progress in Open Source (migrated) Sep 29, 2021
@kestarumper kestarumper mentioned this issue Oct 6, 2021
Merged
Open Source (migrated) automation moved this from In progress to Closed Oct 28, 2021
@radekmie radekmie modified the milestones: v3.x, v3.7 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kestarumper kestarumper

Labels
Type: Feature New features and feature requests
Projects
Open Source
Archived in project
Open Source (migrated)
Closed
Milestone
v3.7
Development

Successfully merging a pull request may close this issue.

Improve typings of getNativeFormProps vazco/uniforms
3 participants
@radekmie @kestarumper @wadamek65