Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about ListField usability. #125

Closed
mattscooter opened this issue Nov 2, 2016 · 4 comments
Closed

Question about ListField usability. #125

mattscooter opened this issue Nov 2, 2016 · 4 comments
Assignees
Labels
Type: Bug Bug reports and their fixes

Comments

@mattscooter
Copy link

I have a set of fields defined as an object array in my schema. This is really similar to the "addresses" example on your demo app.

I have everything working ok, except that I have noticed that when adding a new item to the list by pressing on the add/plus icon any unsaved data entered in the existing fields is cleared out.

From a usability perspective this is bad. Lets say the user adds one set of records and completes the details, then they realise that they want to add a second item. Everything they've entered will be lost. This would be especially annoying for them if the list contains a large number of fields. Also if the user modifies an existing record and then hits add the existing data rows are reverted to the saved data. If the user isn't paying attention then they may miss the fact that their data has been reverted.

The same thing is happening with the remove/minus button.

Is there any way that we can keep any data already entered when the user clicks to add or remove rows?

If you want to see this in action the checkout the addresses example in the demo app.

@radekmie
Copy link
Contributor

radekmie commented Nov 2, 2016

At first I was like: What? Really? Now I've tested it and... Yes - it's a very, very big issue! It was working before, exactly how you described it. I'll take care of it later today.

@radekmie radekmie added the Type: Bug Bug reports and their fixes label Nov 2, 2016
@radekmie radekmie self-assigned this Nov 2, 2016
@radekmie
Copy link
Contributor

radekmie commented Nov 2, 2016

Okay, the issue is right here. If you are not changing the length, then the ListAddField and ListDelField have the old value, so pressing + or - is resetting it. Maybe you want to create a PR for it?

@radekmie
Copy link
Contributor

radekmie commented Nov 2, 2016

Check version 1.4.1.

@mattscooter
Copy link
Author

Thank you so much!

I have just tested 1.4.1 and it's working properly now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug reports and their fixes
Projects
Archived in project
Development

No branches or pull requests

2 participants