-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How up to date is Bootstrap 4 support? #419
Comments
Well, it's a hard question. At first, I'd love to keep all core packages (this repo) up-to-date. Personally, I'm using mainly Material and Semantic UI themes (last one especially). Most projects I've worked in/seen/heard of are using a custom theme (or at least few custom replacements of provided components). I know about at least two production projects using Bootstrap 4 theme - I guess they have own So, let's answer your questions (OK, more general ones). How up-to-date are uniforms? As much as people using it report issues (yes, I'm one of these people too). How is dedicated support planned? I'm trying to do my best here: either help with patching any bugs and incompatibilities or fix it by myself. Bootstrap 4 is somehow special here, as each non-final version had some problems. @janslowik made a bigger update in #386, but this seems to be not included. There's only one thing - if I'm not aware of something, I won't fix it. TL;DR; |
Well, answering questions like mine is one measure of the level of support. Thanks! Only I did not understand what you meant by this seems to be not included? |
I meant that this PR fixed many things but not the labels. |
Gotcha! |
Are you willing to send a PR with a fix or should I treat this issue as a bug report? |
Whichever, I thought I would dig a little deeper to see if there is anything in addition to that. Easier if you fix it... |
@tkurki: OK. I'm a bit busy at the moment, so give it a shot - it looks like an easy one to test. I'll surely have some time this weekend to do it too. |
I am looking into replacing https://github.com/mozilla-services/react-jsonschema-form in https://github.com/SignalK/signalk-server-node/ with Uniforms. SK server supports plugins, that provide the structure of their configuration data in JSON Schema and the server generates the configuration UI from that.
Initial impression is that this might work and Uniforms appears to have solved the problem that plagues RJSF, mainly being stuck with Bootstrap 3.
However I bumped against https://getbootstrap.com/docs/4.0/migration/#labels-and-badges in ListAddField and ListDelField.
That would be easy enough to fix and I can PR that, but this raises the question about how up to date the Bootstrap 4 version is and how dedicated Uniforms is to support Boostrap 4 and the various frameworks. It appears the label-badge renaming took place over 2 years ago.
The text was updated successfully, but these errors were encountered: