Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New theme idea: Bootstrap 5 #874

Closed
michael-vasyliv opened this issue Feb 16, 2021 · 3 comments
Closed

New theme idea: Bootstrap 5 #874

michael-vasyliv opened this issue Feb 16, 2021 · 3 comments
Assignees
Labels
Type: Feature New features and feature requests
Milestone

Comments

@michael-vasyliv
Copy link
Contributor

michael-vasyliv commented Feb 16, 2021

Are you going to create bootstrap 5 project? Have you started yet?

an example of uniforms-bootstrap4 in boostrap5 project
Screenshot from 2021-02-16 16-54-51

Small investigation about differentce between 4 and 5

  1. added a new size xxl
  2. removed marging bottom in form control
  3. removed badge-pill https://getbootstrap.com/docs/5.0/migration/#badges-1
  4. removed form-group https://getbootstrap.com/docs/5.0/migration/#forms-2
  5. renamed fload-right to float-end https://getbootstrap.com/docs/5.0/migration/#utilities-1
@radekmie radekmie self-assigned this Feb 19, 2021
@radekmie radekmie added the Type: Feature New features and feature requests label Feb 19, 2021
@radekmie radekmie added this to Needs triage in Open Source (migrated) via automation Feb 19, 2021
@radekmie
Copy link
Contributor

Hey @michael-vasyliv. No, there is no plan to create a Bootstrap 5 theme, as we are not using Bootstrap at all in the company. However, I encourage you to do that, based on the existing themes (probably uniforms-bootstrap4 would be the best choice), and then file us a PR.

@michael-vasyliv
Copy link
Contributor Author

@radekmie please check #880

@radekmie radekmie changed the title bootstrap5 New theme idea: Bootstrap 5 Feb 19, 2021
@radekmie radekmie moved this from Needs triage to To do in Open Source (migrated) Feb 19, 2021
@radekmie radekmie moved this from To do to In progress in Open Source (migrated) Feb 23, 2021
@radekmie radekmie added this to the v3.3 milestone Mar 24, 2021
@radekmie
Copy link
Contributor

@michael-vasyliv here's the plan for this theme:

  • Finish the PR review.
  • Merge the PR as it is.
  • Release it with the next version.
  • Update playground.
  • Update docs.

@Monteth will take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

No branches or pull requests

2 participants