Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Success field for form validation - wrapField(uniforms-bootstrap4) #899

Closed
Atanasov-A opened this issue Mar 12, 2021 · 1 comment
Closed
Assignees
Labels
Type: Feature New features and feature requests
Milestone

Comments

@Atanasov-A
Copy link

Hello,

thank you very much for your project, we are already using uniforms in a production.
I am using wrapField from uniforms-bootstrap4. When I validate my filled form, and there are errors in a field an error class ('is-invalid') via props.error is set. The invalid fields are painted with a red border and one small red icon is shown. Unfortunately, this behavior is missing for valid inputs in green. I would like to be able to show the user when his input is valid, also with the bootstrap class ('is-valid').
My idea is to adapt in wrapField.tsx:56 these lines:

                "is-invalid": error,
                "is-valid": !error && !!value,
            })}

Would you be interested in this feature? Thank you for considering my request.

@radekmie radekmie self-assigned this Mar 15, 2021
@radekmie radekmie added the Type: Feature New features and feature requests label Mar 15, 2021
@radekmie radekmie added this to Needs triage in Open Source (migrated) via automation Mar 15, 2021
@radekmie radekmie moved this from Needs triage to To do in Open Source (migrated) Mar 15, 2021
@radekmie radekmie added this to the v3.3 milestone Mar 15, 2021
@radekmie
Copy link
Contributor

Hi @Atanasov-A. Yep, that'd make a great feature. However, I'm concerned about it being a change. Maybe we could display it only for changed fields? What do you think?

@Monteth Monteth self-assigned this Apr 14, 2021
Open Source (migrated) automation moved this from To do to Closed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

No branches or pull requests

3 participants