Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issuer Metadata Problem wrt OID4VCI Draft13 #463

Open
vanhoanHoang opened this issue Jun 3, 2024 · 2 comments
Open

Issuer Metadata Problem wrt OID4VCI Draft13 #463

vanhoanHoang opened this issue Jun 3, 2024 · 2 comments
Assignees

Comments

@vanhoanHoang
Copy link

vanhoanHoang commented Jun 3, 2024

I have pulled all tested the v0.3 release and identify that we might have a problem related to metadata defined in the OID4VCI Draft 13.

In the Draft 13, for each element in credential_configurations_supported, there must be a credential_definition object which contains type and multiple optional properties.

However, by looking at the metadata in the Issuer API, I see that there are not credential_definition object in each supported credential configuration. More specifically, below is what exposed by Issuer API

{
    "BankId_jwt_vc_json": {
      "id": "BankId_jwt_vc_json",
      "format": "jwt_vc_json",
      "cryptographic_binding_methods_supported": [
        "did"
      ],
      "cryptographic_suites_supported": [
        "EdDSA",
        "ES256",
        "ES256K",
        "RSA"
      ],
      "types": [
        "VerifiableCredential",
        "BankId"
      ]
}

while the following should be exposed instead:

{
   "BankId_jwt_vc_json":{
      "id":"BankId_jwt_vc_json",
      "format":"jwt_vc_json",
      "cryptographic_binding_methods_supported":[
         "did"
      ],
      "cryptographic_suites_supported":[
         "EdDSA",
         "ES256",
         "ES256K",
         "RSA"
      ],
      "credential_definition":{
         "types":[
            "VerifiableCredential",
            "BankId"
         ]
      }
   }
}

Can you have a look at it ?

Cheer,
Hoan

@chsavvaidis chsavvaidis self-assigned this Jun 4, 2024
@alegomes
Copy link
Contributor

alegomes commented Jun 4, 2024

Thanks so much for your report, Hoan. It's a very nice contribution. We'll tackle it as soon as possible.

@severinstampler
Copy link
Contributor

@chsavvaidis when you tackle this problem, please also take into consideration, that this credential_definition parameter only is used for W3C verifiable credentials. There's a different format for ISO/mdoc and IETF/sd-jwt-vc, which we should also support. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants