Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename id fields in JS API to be more foolproof #118

Open
cormacrelf opened this issue Jul 2, 2021 · 0 comments
Open

Rename id fields in JS API to be more foolproof #118

cormacrelf opened this issue Jul 2, 2021 · 0 comments

Comments

@cormacrelf
Copy link
Collaborator

While I'm at it breaking compatibility in favour of usability, I might also kill the reuse of the field name "id" to refer to every different kind of ID. clusterId on a Cluster, refId on a Cite because it points to a Reference. Then you won't have so many accidents like earlier in this issue.

Originally posted by @cormacrelf in #117 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cormacrelf