Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TxInfo property name discrepancy, and missing index. #1266

Closed
wajda opened this issue Sep 4, 2023 · 0 comments · Fixed by #1267
Closed

TxInfo property name discrepancy, and missing index. #1266

wajda opened this issue Sep 4, 2023 · 0 comments · Fixed by #1267
Assignees
@wajda
Labels
bug component: Persistence
Milestone
1.0.0

Comments

@wajda
Copy link
Contributor

wajda commented Sep 4, 2023

  1. It is stored as _txInfo but is queried as _tx_info. It should be _txInfo everywhere.
  2. There is no index on _txInfo that causes too slow rollback on very large collections (see Spline getting hanged due to long running queries on Arango #1264)
@wajda wajda added the bug label Sep 4, 2023
@wajda wajda added this to the 1.0.0 milestone Sep 4, 2023
@wajda wajda self-assigned this Sep 4, 2023
wajda added a commit that referenced this issue Sep 5, 2023
@wajda
issue #1266 Rename wrongly named property _tx_info to correct `_txI…
fe1ea4b 
…nfo`
wajda added a commit that referenced this issue Sep 5, 2023
@wajda
issue #1266 Delete documents of the rolling back transaction by compa…
43b8c37 
…ring the `_txInfo.uid` property only (no need to look at other '_txInfo.*' props)
wajda added a commit that referenced this issue Sep 5, 2023
@wajda
issue #1266 Add persistent index on _txInfo.uid property to all nod…
2563feb 
…es and edges
wajda added a commit that referenced this issue Sep 5, 2023
@wajda
issue #1266 Fix some ArangoDb driver deprecations
7d04d6f
@wajda wajda mentioned this issue Sep 5, 2023
Merged
wajda added a commit that referenced this issue Sep 6, 2023
@wajda
issue #1266 Minor refactoring: rename "ArangoManager.initialize()" to…
1db3135 
… "createDatabase()"
wajda added a commit that referenced this issue Sep 6, 2023
@wajda
issue #1266 Add tests for "ArangoManager.createDatabase"
65632b4
wajda added a commit that referenced this issue Sep 6, 2023
@wajda
Bugfix/spline 1266 tx info discrepancy and index (#1267)
3143bbc 
* issue #1266 Rename wrongly named property `_tx_info` to correct `_txInfo`

* issue #1266 Delete documents of the rolling back transaction by comparing the `_txInfo.uid` property only (no need to look at other '_txInfo.*' props)

* issue #1266 Add persistent index on `_txInfo.uid` property to all nodes and edges

* issue #1266 Fix some ArangoDb driver deprecations

* issue #1266 Minor refactoring: rename "ArangoManager.initialize()" to "createDatabase()"

* issue #1266 Add tests for "ArangoManager.createDatabase"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wajda wajda

Labels
bug component: Persistence
Projects
Spline
Status: Done
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Bugfix/spline 1266 tx info discrepancy and index AbsaOSS/spline
1 participant
@wajda