SITL: remove duplicated crc code #27456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
same as one we already have
|
I'd like to tackle this sort of thing in a bit more cohesive manner: #27355 Don't think this should affect merging of this but if you'd like to weigh in. |
I've weighed in. I suggest you PR a separate branch on top of your existing PR branch which merges the ccitt and xmodem implementations if they are, indeed, duplicates. Bringing a PR which saves a kilobyte is a good strategy to getting this sort of thing merged IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as one we already have
... also the one used in the driver itself