Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure.AKS.MinNodeCount Enhancement #2683

Closed
BernieWhite opened this issue Feb 9, 2024 Discussed in #2671 · 0 comments · Fixed by #2697
Closed

Azure.AKS.MinNodeCount Enhancement #2683

BernieWhite opened this issue Feb 9, 2024 Discussed in #2671 · 0 comments · Fixed by #2697
Assignees
@BernieWhite
Labels
enhancement New feature or request rule: azure-kubernetes-service Rules for Azure Kubernetes Service
Milestone
v1.34.0

Comments

@BernieWhite
Copy link
Collaborator

Discussed in #2671

Originally posted by paulmcclbg February 5, 2024
The above rule checks for the first array member has a min count of 3

field: 'Properties.agentPoolProfiles[0].count'

We have clusters with more than one agent pool and the rule is failing because the first pool in the array only has 2 nodes, whereas the second pool in the array does have 3.

We need the ability to narrow the rule to a specific pool.
@BernieWhite BernieWhite added enhancement New feature or request rule: azure-kubernetes-service Rules for Azure Kubernetes Service labels Feb 9, 2024
BernieWhite added a commit to BernieWhite/PSRule.Rules.Azure that referenced this issue Feb 21, 2024
@BernieWhite
AKS min node improvements Azure#2683
105e0d4
@BernieWhite BernieWhite mentioned this issue Feb 21, 2024
Merged
8 tasks
@BernieWhite BernieWhite added this to the v1.34.0 milestone Feb 21, 2024
@BernieWhite BernieWhite self-assigned this Feb 21, 2024
BernieWhite added a commit that referenced this issue Feb 21, 2024
@BernieWhite
AKS min node improvements #2683 (#2697)
f29a483 
* AKS min node improvements #2683

* Bump docs
This was referenced Feb 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BernieWhite BernieWhite

Labels
enhancement New feature or request rule: azure-kubernetes-service Rules for Azure Kubernetes Service
Projects
None yet
Milestone
v1.34.0
Development

Successfully merging a pull request may close this issue.

AKS min node improvements #2683 BernieWhite/PSRule.Rules.Azure
1 participant
@BernieWhite