bastille cmd exit code not respected #272 #303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there are 2 possibilities, execute a command in 1 jail or in all running jails.
When executing in one jail. I returned the right exit code:
root@bastille:
# bastille cmd test cat /etc/passwd# echo $?[test - Return code]: 0
root@bastille:
0
root@bastille:~ # bastille cmd test more xxx
[test]:
xxx: No such file or directory
[test - Return code]: 1
root@bastille:~ # echo $?
1
root@bastille:~ # bastille cmd test diff /test1 /test2
[test]:
diff: /test1: No such file or directory
[test - Return code]: 2
root@bastille:~ # echo $?
2
Running a command in all running jails:
After each jail, I returned the exit code. If everything runs fine, I return "0", otherwise "1"
root@bastille:~ # bastille cmd ALL diff /test1 /test2
[test]:
diff: /test1: No such file or directory
[test - Return code]: 2
[test1]:
diff: /test1: No such file or directory
[test1 - Return code]: 2
root@bastille:~ # echo $?
1