Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script reports files as same size, doesn't calculate total cumulative storage difference #27

Closed
hwwilliams opened this issue Oct 23, 2017 · 3 comments
Closed

Script reports files as same size, doesn't calculate total cumulative storage difference #27

hwwilliams opened this issue Oct 23, 2017 · 3 comments
Assignees
@BrianDMG
Labels
Bug

Comments

@hwwilliams
Copy link

shot_171022_210909
shot_171022_210930

A gig in file difference, says same file size in the script output.

shot_171022_212117

This isn't a huge deal obviously, the script still converts fine. But I thought you'd like to know something isn't working as intended because I do like to occasionally see the space I'm saving.
@BrianDMG BrianDMG self-assigned this Oct 23, 2017
@BrianDMG BrianDMG added the Bug label Oct 23, 2017
@BrianDMG
Copy link
Owner

Weird, I'll look into it. Thanks for pointing it out!

BrianDMG added a commit that referenced this issue Oct 24, 2017
@BrianDMG
v3.1.2
524997c 
* New method of calculating per-encode and cumulative disk usage change
* Calculated values are more accurate now, being compared to a 1024 base
instead of 1000
* This bugfix is intended to address issue #27
@BrianDMG
Copy link
Owner

Just published a beta to fix this issue on the bugfix-diskusage branch. I didn't have many videos to test on, so I committed it to this branch for testing for a few days until I have enough data. Feel free to check it out and let me know how it works out for you. My limited tests have been positive.

@BrianDMG BrianDMG mentioned this issue Oct 25, 2017
Merged
BrianDMG added a commit that referenced this issue Oct 25, 2017
@BrianDMG
v3.1.2
e2d238b 
* New method of calculating per-encode and cumulative disk usage change
* Calculated values are more accurate now - using a 1024 base
instead of 1000
* Closes issue #27
* Removed unnecessary whitespace
@BrianDMG
Copy link
Owner

Code merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrianDMG BrianDMG

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BrianDMG @hwwilliams