Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(query): add CWE information to volume_has_sensitive_host_directory #7153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

julianthome
Copy link

** Reason for Proposed Changes**

  • CWE information for the query was missing

** Proposed Changes**

  • Adding 668 as Exposure of Resource to Wrong Sphere seems the best fit covering both confidentiality and integrity concerns.

I submit this contribution under the Apache-2.0 license.

Adding 668 as Exposure of Resource to Wrong Sphere seems the best fit covering both confidentiality and integrity concerns.
@julianthome julianthome requested a review from a team as a code owner June 25, 2024 12:18
@github-actions github-actions bot added community Community contribution query New query feature labels Jun 25, 2024
@julianthome julianthome changed the title Add CWE information Add CWE information to volume_has_sensitive_host_directory Jun 25, 2024
@julianthome julianthome changed the title Add CWE information to volume_has_sensitive_host_directory update(query): add CWE information to volume_has_sensitive_host_directory Jun 25, 2024
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @julianthome,
Thanks for your the contribution!
At the moment, the query metadata does not have 2 required fields, which is causing the e2e tests to fail, as you can see in the actions pipeline below.
Can you kindly add oldSeverity and cloudProvider fields to the metadata, like so:

(other query's metadata fields)
"descriptionID": "8361cc0a",
"oldSeverity": "HIGH",
"cloudProvider": "common",
"cwe": "668"
}
As soon as you do, I'll approve the PR.

Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants