Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stat split #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stat split #13

wants to merge 1 commit into from

Conversation

jelu
Copy link
Member

@jelu jelu commented May 30, 2024

  • Add queries_responses_obj to split stats
  • stats:
    • Change queries and responses to sent and received with the type of queries_responses_obj
    • Change timeouts to a queries_responses_obj
    • Change interrupted to a queries_responses_obj
    • Change unexpected to a queries_responses_obj
    • Change discarded to a queries_responses_obj

- Add `queries_responses_obj` to split stats
- `stats`:
  - Change `queries` and `responses` to `sent` and `received` with the type of `queries_responses_obj`
  - Change `timeouts` to a `queries_responses_obj`
  - Change `interrupted` to a `queries_responses_obj`
  - Change `unexpected` to a `queries_responses_obj`
  - Change `discarded` to a `queries_responses_obj`
@jelu jelu requested a review from a team May 30, 2024 08:48
@jelu
Copy link
Member Author

jelu commented May 30, 2024

This split changes some of the stats properties to be either an object or a counter, maybe too complex, donno. Discuss :)

@pspacek
Copy link

pspacek commented May 30, 2024

Seems like an overkill to me, and potentially confusing. Some things might not be applicable - e.g. timeout of sending stuff etc.

@nicki-krizek
Copy link

I don't like the complexity and the potential confusion it brings. Someone could mistakenly use this:

"sent": {
  "queries": 100,
  "responses": 90
}

when they meant to write this instead:

"sent": {
  "queries": 100
},
"received": {
  "responses": 90
}

On the other hand, being able to specify that responses were sent / queries received makes the format more flexible for tracking server-side data, which is nice...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants