Use valid DNS queries as largest UDP and TCP test payloads #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a python script to actually generate these blobs and possibly |
EDNS0 option PADDING is used to inflate the queries.
Largest UDP payload over IPv4 is 65507 bytes, 65527 for the IPv6.
We go with IPv4. Oversized payloads are already tested using largest TCP
payload (65535 bytes).
Generated with dnspython 2.6.1:
import dns.message
m = dns.message.make_query('.', 'TYPE666')
print(len(m.to_wire(max_size=65535)))
m.options.append(dns.edns.GenericOption(dns.edns.OptionType.PADDING, '\x00' * 65475))
print(len(m.to_wire(max_size=65535)))
binary = m.to_wire(max_size=65535)
import struct
binary = struct.pack('>H', len(binary)) + binary
open('output.blob', 'wb').write(binary)
- Add script to generate largest blobs
jelu
force-pushed
the
fix-large-binary-tests
branch
from
1f388c7
to
1ef5b41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.