apm: rm deprecated peer_service_aggregation config

[ahmed-mez]

What does this PR do?

AIT-9878

Complete the deprecation of peer_service_aggregation that started in this commit https://github.com/DataDog/datadog-agent/pull/20550/files#diff-a77843a3a2d99bdc21000210a1c6a0fc99871774b33d15b6779389e8299aa794

Motivation

Clean up deprecated beta parameters in the trace-agent

Additional Notes

The corresponding docs PR is DataDog/documentation#21991

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

The new parameter peer_tags_aggregation is unit tested.

[pr-commenter]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 1a1c819d-6b58-4e0f-9c95-d43ad34410b3
Baseline: d40837d
Comparison: 268db96

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Experiments with missing or malformed data

• basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	-0.42	[-6.94, +6.10]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	process_agent_standard_check	memory utilization	+0.34	[+0.30, +0.37]
➖	process_agent_real_time_mode	memory utilization	+0.20	[+0.16, +0.23]
➖	trace_agent_msgpack	ingress throughput	+0.02	[+0.00, +0.03]
➖	trace_agent_json	ingress throughput	+0.01	[-0.01, +0.03]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.00, +0.00]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	process_agent_standard_check_with_stats	memory utilization	-0.04	[-0.07, -0.01]
➖	idle	memory utilization	-0.40	[-0.44, -0.37]
➖	file_to_blackhole	% cpu utilization	-0.42	[-6.94, +6.10]
➖	file_tree	memory utilization	-0.72	[-0.79, -0.66]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.77	[-2.19, +0.66]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.84	[-0.89, -0.79]
➖	otel_to_otel_logs	ingress throughput	-1.13	[-1.75, -0.50]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[ahmed-mez]

To be merged for v7.54.0

[pr-commenter]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=31244521 --os-family=ubuntu

[ahmed-mez]

/merge

[dd-devflow]

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: 85c45200-b9d1-46cf-8891-670faa31f2a0
Baseline: 6294adc
Comparison: 45b3693

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.83	[-5.45, +7.11]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	basic_py_check	% cpu utilization	+1.70	[-0.91, +4.32]
➖	file_tree	memory utilization	+1.29	[+1.18, +1.40]
➖	file_to_blackhole	% cpu utilization	+0.83	[-5.45, +7.11]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.67	[-2.28, +3.62]
➖	idle	memory utilization	+0.37	[+0.33, +0.42]
➖	process_agent_standard_check	memory utilization	+0.32	[+0.27, +0.38]
➖	process_agent_standard_check_with_stats	memory utilization	+0.30	[+0.26, +0.34]
➖	process_agent_real_time_mode	memory utilization	+0.20	[+0.16, +0.24]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.01	[-0.01, +0.03]
➖	trace_agent_json	ingress throughput	+0.01	[-0.01, +0.03]
➖	trace_agent_msgpack	ingress throughput	+0.00	[-0.00, +0.00]
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.20, +0.20]
➖	otel_to_otel_logs	ingress throughput	-0.10	[-0.50, +0.31]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.14	[-0.22, -0.05]
➖	pycheck_1000_100byte_tags	% cpu utilization	-0.43	[-5.35, +4.49]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".