Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENV required:false still forcing user to set value in setup console #232

Open
scosman opened this issue Nov 3, 2022 · 4 comments
Open
Assignees

Comments

@scosman
Copy link

scosman commented Nov 3, 2022

I have an open source project using Cloud Run + app.json to specify env vars.

Even though required=false in app.json, in the console I get the error message Sorry, your reply was invalid: Value is required if I try to skip setting it (via enter). It looks like required=false isn't being respected?

https://github.com/scosman/zipstreamer/tree/docker-docs

@glasnt glasnt self-assigned this Nov 3, 2022
@jamesward
Copy link
Contributor

Can you try to remove the required key? (false is the default) Maybe the parsing of the false value is wrong.

@glasnt
Copy link
Collaborator

glasnt commented Nov 3, 2022

@jamesward
Copy link
Contributor

Oh right. I got that backwards. I think that what might be needed to make this work is the default value which could (hopefully) be set to an empty string, like:

"value": ""

scosman added a commit to scosman/zipstreamer that referenced this issue Nov 3, 2022
@scosman
Copy link
Author

scosman commented Nov 3, 2022

I'm still seeing the issue with "value": "". And not to nit, but an empty string might be handled differently than no value in some apps. An easy way to skip non-required ENV vars would be nice. Thank you!!

Test file:
https://github.com/scosman/zipstreamer/blob/cloudrun_fix_required/app.json

CR Link:
https://deploy.cloud.run?git_repo=https%3A%2F%2Fgithub.com%2Fscosman%2Fzipstreamer?revision=cloudrun_fix_required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants