Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The $PORT in the log message is a literal #90

Open
ferrarimarco opened this issue Apr 17, 2024 · 2 comments
Open

The $PORT in the log message is a literal #90

ferrarimarco opened this issue Apr 17, 2024 · 2 comments

Comments

@ferrarimarco
Copy link
Member

Hi folks!

When deploying this service on Cloud Run, the $PORT is printed as a literal in the log:

2024/04/17 14:13:36 Hello from Cloud Run! The container started successfully and is listening for HTTP requests on $PORT

Shall this be formatted?

cloud-run-hello/hello.go

Line 188 in 7e45d10

log.Print("Hello from Cloud Run! The container started successfully and is listening for HTTP requests on $PORT")

Thanks for your support!
JulienBreux added a commit to JulienBreux/cloud-run-hello that referenced this issue Jul 2, 2024
@JulienBreux
fix: output message with litteral port. fix GoogleCloudPlatform#90
9382879
@JulienBreux JulienBreux mentioned this issue Jul 2, 2024
Open
@JulienBreux
Copy link
Member

Hi @ferrarimarco,

Thanks for contributing.

Fix in progress.

Have a nice day :)

@ferrarimarco
Copy link
Member Author

Thanks @JulienBreux !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ferrarimarco @JulienBreux