Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore , refactor : removed ! rm lightweight_pipeline.json , Added cleanup code for deletion of pipeline and refactored code according to template guidelines , performed linter test #3149

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Jayakrishna2801
Copy link

@Jayakrishna2801 Jayakrishna2801 commented Jun 26, 2024

This PR includes the following updates:

Adds Colab Enterprise link and other structural changes from the new template.
Changes REGION variable name to LOCATION
Adds clean up code for pipeline deletion
Removes IS_TESTING from the cleaning up section.
Removes the usage of future tense.

REQUIRED: Fill out the below checklists or remove if irrelevant

  1. If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:
  • Use the notebook template as a starting point.
  • Follow the style and grammar rules outlined in the above notebook template.
  • Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
  • Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
  • You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
  • This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
  • The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

  1. If you are opening a PR for Community Notebooks under the notebooks/community folder:
  • This notebook has been added to the CODEOWNERS file under the Community Notebooks section, pointing to the author or the author's team.
  • Passes all the required formatting and linting checks. You can locally test with these instructions.

  1. If you are opening a PR for Community Content under the community-content folder:
  • Make sure your main Content Directory Name is descriptive, informative, and includes some of the key products and attributes of your content, so that it is differentiable from other content
  • The main content directory has been added to the CODEOWNERS file under the Community Content section, pointing to the author or the author's team.
  • Passes all the required formatting and linting checks. You can locally test with these instructions.

@Jayakrishna2801 Jayakrishna2801 requested a review from a team as a code owner June 26, 2024 14:55
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@kittyabs kittyabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested edits

"* Vertex AI\n",
"* Cloud Storage\n",
"\n",
"Learn about [Vertex AI\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be put on one line?

"Learn about Vertex AI\n",
"pricing

e.g.,

"Learn about Vertex AI pricing

Jayakrishna2801 added 2 commits June 27, 2024 06:36
…ctored code according to template guidelines , performed linter test
…ctored code according to template guidelines , performed linter test
@Jayakrishna2801 Jayakrishna2801 changed the title refactor : removed ! rm lightweight_pipeline.json chore , refactor : removed ! rm lightweight_pipeline.json , Added cleanup code for deletion of pipeline and refactored code according to template guidelines , performed linter test Jun 27, 2024
@gericdong
Copy link
Contributor

/gcbrun

…ode according to template guidelines , performed linter test
@katiemn
Copy link
Collaborator

katiemn commented Jun 27, 2024

/gcbrun

@katiemn
Copy link
Collaborator

katiemn commented Jul 1, 2024

/gcbrun

@katiemn
Copy link
Collaborator

katiemn commented Jul 2, 2024

/gcbrun

@katiemn
Copy link
Collaborator

katiemn commented Jul 3, 2024

Please take a look at the format and lint failures

@gericdong
Copy link
Contributor

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants