Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startup/bootsnap: raise repeated LoadError. #17177

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

MikeMcQuaid
Copy link
Member

If HOMEBREW_BOOTSNAP_RETRY was set then we should raise the LoadError the second time so that the failures are user visible for debugging.

If `HOMEBREW_BOOTSNAP_RETRY` was set then we should raise the
`LoadError` the second time so that the failures are user visible for
debugging.
Library/Homebrew/startup/bootsnap.rb Outdated Show resolved Hide resolved
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@MikeMcQuaid MikeMcQuaid merged commit abd1b48 into master Apr 29, 2024
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the bootsnap_raise_load_error branch April 29, 2024 16:52
@MikeMcQuaid
Copy link
Member Author

Thanks @carlocab!

@github-actions github-actions bot added the outdated PR was locked due to age label May 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants