install-bundler-gems: change_privilege when necessary.
#17178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
reviewed
Apr 29, 2024
Library/Homebrew/utils/gems.rb
Outdated
| @@ -296,6 +296,7 @@ def install_bundler_gems!(only_warn_on_failure: false, setup_path: true, groups: | |||
| end | |||
|
|
|||
| bundle_installed = if bundle_install_required | |||
| Process::UID.change_privilege(Process.euid) if Process.euid != Process.uid | |||
There was a problem hiding this comment.
Seems correct. I think you can make this temporary by doing something like
begin
original_uid = Process.uid
Process::UID.change_privilege(Process.euid)
...
ensure
Process::UID.change_privilege(original_uid)
endThere was a problem hiding this comment.
@carlocab Unfortunately we get Error: Operation not permitted on the latter call. I've scoped this to brew install-bundler-gems instead for now.
There was a problem hiding this comment.
@Bo98 When you're back could do with your help figuring out how to do this better for bundle install.
This ensures that gems are able to be installed when using e.g. `ruby -I` in their installation scripts.
MikeMcQuaid
force-pushed
the
gems_change_privilege
branch
from
32c30bb
to
65f3df9
Compare
MikeMcQuaid
changed the title
change_privilege when necessary.change_privilege when necessary.
carlocab
approved these changes
Apr 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that gems are able to be installed when using e.g.
ruby -Iin their installation scripts.Leaving this as draft for now as I'm not convinced this is the right approach; this should be a temporary change just for
bundle install. I was unclear how to do that though CC @Bo98 for help when you're back.