Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various: add rosetta caveats [0-9a-c] #178000

Merged
merged 40 commits into from
Jun 30, 2024

Conversation

wickles
Copy link
Contributor

@wickles wickles commented Jun 27, 2024

Partial test/followup for #177913 (part 1)

@wickles
Copy link
Contributor Author

wickles commented Jun 27, 2024

Some spurious failures related to Homebrew/brew#17573

Failed to determine artifact architecture!

even with atom which is just one single intel binary in the app.

❯ lipo -archs Atom.app/Contents/MacOS/Atom
x86_64

@SMillerDev
Copy link
Member

The amazon-music failure is because it does not support the macOS version, so that probably needs to be deprecated.

@wickles
Copy link
Contributor Author

wickles commented Jun 28, 2024

That Amazon Music app probably would be compatible with rosetta but they have that weird install script causing problems. I've removed the change from this PR.

Also reverted change to bluestacks since the Bluestacks X app is universal despite the url containing x64 (false positive).

@SMillerDev
Copy link
Member

Please split this in one commit per cask.

@wickles
Copy link
Contributor Author

wickles commented Jun 28, 2024

Please split this in one commit per cask.

I really would rather not. Why?

@bevanjkay
Copy link
Member

I really would rather not. Why?

It is standard practice in all Homebrew repositories, it keep commit history cleaner and makes it easier to revert individual changes as required.

@wickles
Copy link
Contributor Author

wickles commented Jun 30, 2024

I see, thanks for clarifying. Is this expectation documented somewhere for contributors? (found here) And can you suggest some tool or snippet to simplify the task? Thanks.

Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wickles ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@SMillerDev SMillerDev merged commit c6f6732 into Homebrew:master Jun 30, 2024
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants