Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Transfer-Encoding: chunked header #51

Merged
merged 4 commits into from
Oct 13, 2020
Merged

Conversation

jbahillo
Copy link
Contributor

Jira instances behind a reverse proxy would require
Content-Lenght value or Transfer-Encoding set to chunked.

Some more info might be found here: https://bugs.php.net/bug.php?id=79013&edit=1 despite
the issue mentioned here is not exactly the same (thy're referring to HTTP/2.

    Jira instances behind a reverse proxy would require
    Content-Lenght value or Transfer-Encoding set to chunked.
    
    Some more info might be found here: https://bugs.php.net/bug.php?id=79013&edit=1 despite
    the issue mentioned here is not exactly the same (thy're referring to HTTP/2.
Copy link
Collaborator

@Thomas-Gelf Thomas-Gelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Please use Content-Length (strlen -> body), and apply it only in case there is a body

@jbahillo
Copy link
Contributor Author

Requested change performed

Copy link
Collaborator

@Thomas-Gelf Thomas-Gelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

library/Jira/RestApi.php Outdated Show resolved Hide resolved
@Thomas-Gelf Thomas-Gelf merged commit 4af3112 into Icinga:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants