-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make templates and their corresponding fields configurable in UI #95
Conversation
491282c
to
cbe7526
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks promising. If I understand this correctly, this not only allows you to include "arrays" like requested in #88, but furthermore allows you to select (?) custom JIRA fields to fill with values from Icinga and make those even configurable from the configuration page in Icinga.
I found that it's not possible to define custom fields that require other key-value pairs from the templates config file. Example:
customfield_10184 = '{ "id": "22806" }'
isn't working.
Will this be possible with your approach? I will create a new issue otherwise.
Update: I just found that this occurs when the custom field type is "option" - which you excluded here, probably because the assignment of "free" values from data fields in Icinga possibly won't match these possible values. Some installations do have such fields configured as required though, so it would be great to include them, too. Maybe it's possible to just add a warning about this problem when configuring the field?
cabf056
to
859ccca
Compare
859ccca
to
bf2c2d9
Compare
Hi @verboEse, |
bf2c2d9
to
e660b80
Compare
I'm not sure how this is accomplished, but in WebUI I get a drop-down when trying to change the field and only the offered values are allowed for the custom field. |
60d5d24
to
243cc38
Compare
4be19fd
to
9a24d12
Compare
9a24d12
to
323e92f
Compare
cc81149
to
66631e2
Compare
ce8beca
to
a99c320
Compare
@verboEse, currently only string, number or array (only labels) type custom fields are supported for configuration in the Web GUI.
Or in case of multi-select custom field:
Update: You could either use |
a99c320
to
1e531b1
Compare
You can configure a template to be used while creating the issues in this tab. Also, list all the configured templates.
The fields to be added to the specific configured template will be added here.
Also, make changes to IssueTemplate class to allow arrays to be sent to the jira fields.
…rm` as base form for NewIssueForm Since Icinga\Module\Jira\Web\Form, library/Jira/Web/Form/LegacyDecorator, form-compat26 css class and changes to form-element-description css class are removed.
1e531b1
to
cfe63d5
Compare
The templates and their corresponding has been configurable in UI.
This PR also include changes to allow passing arrays to Jira Tickets.
ref #88