[feat] Added in blog-site #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adding |
|
also you should have separate pr for separate issue |
|
@Kritika30032002 That issue wasn't that big so I didn't create a new pull request, but for future I will keep that in mind. I have used css now to avoid overlapping of footer and other page's content. |
|
see the highlighted code line |
So I should use margin instead to spaces? |
|
yes |
|
now its good. @Kritika30032002 Thankyou for your guidance and patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#108 #152 all overlapping of footer from all pages are fixed and signup with google OAuth credentials is also added in the signup page,
After:
Before:
I have removed firebase config details due to security reasons, but I am also beginner and don't know if its okay, so if it is I can add those details too. @Kritika30032002