Spot termination checking #390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
golangcibot
reviewed
Jan 27, 2020
core/main.go
Outdated
| @@ -210,7 +210,12 @@ func (a *AutoSpotting) EventHandler(event *json.RawMessage) { | |||
| return | |||
| } else if instanceID != nil { | |||
| spotTermination := newSpotTermination(cloudwatchEvent.Region) | |||
| spotTermination.executeAction(instanceID, a.config.TerminationNotificationAction) | |||
| if spotTermination.isInAutoSpottingASG(instanceID, a.config.TagFilteringMode, a.config.FilterByTags) { | |||
| spotTermination.executeAction(instanceID, a.config.TerminationNotificationAction) | |||
There was a problem hiding this comment.
Error return value of spotTermination.executeAction is not checked (from errcheck)
gabegorelick
force-pushed
the
spot_termination_checking
branch
from
69f85e0
to
e2d800a
Compare
|
I have no idea what these lint errors are about. The referenced lines don't exist in |
gabegorelick
added a commit
to gabegorelick/AutoSpotting
that referenced
this pull request
Jan 27, 2020
This is a reworking of LeanerCloud#363 against `master`. Credit for original code goes to @cfarrend. Closes LeanerCloud#363 Closes LeanerCloud#390
13 tasks
gabegorelick
added a commit
to gabegorelick/AutoSpotting
that referenced
this pull request
Jan 27, 2020
This is a reworking of LeanerCloud#363 against `master`. Credit for original code goes to @cfarrend. Fixes LeanerCloud#362 Closes LeanerCloud#363 Closes LeanerCloud#390
gabegorelick
added a commit
to gabegorelick/AutoSpotting
that referenced
this pull request
Jan 27, 2020
This is a reworking of LeanerCloud#363 against `master`. Credit for original code goes to @cfarrend. Fixes LeanerCloud#362 Closes LeanerCloud#363 Closes LeanerCloud#390
|
Closing this in favor of #391 which targets master. |
gabegorelick
added a commit
to gabegorelick/AutoSpotting
that referenced
this pull request
Jan 28, 2020
This is a reworking of LeanerCloud#363 against `master`. Credit for original code goes to @cfarrend. Fixes LeanerCloud#362 Closes LeanerCloud#363 Closes LeanerCloud#390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Type
Feature Pull Request
Summary
#363 with an extra commit to add tests.
Code contribution checklist
code under any software license.
to it.
guidelines.
test coverage doesn't decrease.
make full-test.variables which are also passed as parameters to the
CloudFormation
and
Terraform
stacks defined as infrastructure code.
support per-group overrides using tags.
configurations.
proven to work using log output from various test runs.
appropriate) and formatted consistently to the existing log output.
new configuration options for both stack parameters and tag overrides.
contribution actually resolves it.