Move logs about incompatible instance types to debug #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the amount of logs generated when replacing a large number of on-demand instances could be overwhelming since info about each candidate instance type was logged. Now, we still log when an instance type matches, but now all the logs about every instance type that does not match will be at debug level. This change was begun in https://github.com/AutoSpotting/AutoSpotting/pull/354/files#diff-fa23d3c4fb090da3bc9f71371d6e1d95R446.
gabegorelick
force-pushed
the
comparison-logs
branch
from
67d8d6e
to
015a284
Compare
|
Code Climate has analyzed commit 015a284 and detected 0 issues on this pull request. View more on Code Climate. |
gabegorelick
commented
Feb 4, 2020
| @@ -243,7 +243,7 @@ func (a *autoScalingGroup) loadConfSpot() bool { | |||
| } | |||
| if newValue, done := a.loadBiddingPolicy(tagValue); done { | |||
| a.region.conf.BiddingPolicy = newValue | |||
| logger.Println("BiddingPolicy =", a.region.conf.BiddingPolicy) | |||
| debug.Println("BiddingPolicy =", a.region.conf.BiddingPolicy) | |||
There was a problem hiding this comment.
I don't think this adds anything since the default bidding policy was already logged on startup.
gabegorelick
commented
Feb 4, 2020
| @@ -460,16 +460,16 @@ func (i *instance) launchSpotReplacement() error { | |||
| func (i *instance) getPricetoBid( | |||
| baseOnDemandPrice float64, currentSpotPrice float64) float64 { | |||
|
|
|||
| logger.Println("BiddingPolicy: ", i.region.conf.BiddingPolicy) | |||
| debug.Println("BiddingPolicy: ", i.region.conf.BiddingPolicy) | |||
There was a problem hiding this comment.
The 2 logs statements below are enough to infer the bidding policy.
gabegorelick
commented
Feb 4, 2020
| @@ -391,7 +391,7 @@ func (i *instance) getCompatibleSpotInstanceTypesListSortedAscendingByPrice(allo | |||
| i.isStorageCompatible(candidate, attachedVolumesNumber) && | |||
| i.isVirtualizationCompatible(candidate.virtualizationTypes) { | |||
| acceptableInstanceTypes = append(acceptableInstanceTypes, acceptableInstance{candidate, candidatePrice}) | |||
| logger.Println("\tMATCH FOUND, added", candidate.instanceType, "to launch candiates list") | |||
| logger.Println("\tMATCH FOUND, added", candidate.instanceType, "to launch candiates list for instance", i.InstanceId) | |||
There was a problem hiding this comment.
Adding instanceID to some of these logs to help provide context.
cristim
approved these changes
Feb 4, 2020
|
Thanks for merging this so quickly @cristim. |
|
Thanks for your contribution! I'm doing my best to keep up with you and get these things merged and delivered to the users timely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the amount of logs generated when replacing a large
number of on-demand instances could be overwhelming since info about
each candidate instance type was logged. Now, we still log when an
instance type matches, but now all the logs about every instance type
that does not match will be at debug level.
This change was begun in https://github.com/AutoSpotting/AutoSpotting/pull/354/files#diff-fa23d3c4fb090da3bc9f71371d6e1d95R446.
Issue Type
Summary
Reduce amount of logs generated when attempting to find compatible instance types.
Code contribution checklist
code under any software license.
to it.
guidelines.
test coverage doesn't decrease.
make full-test.variables which are also passed as parameters to the
CloudFormation
and
Terraform
stacks defined as infrastructure code.
support per-group overrides using tags.
configurations.
proven to work using log output from various test runs.
appropriate) and formatted consistently to the existing log output.
new configuration options for both stack parameters and tag overrides.
contribution actually resolves it.