Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Hilt #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

naufalprakoso
Copy link

Overview

In the last few months, Google release Hilt. Hilt is a dependency injection library for Android that reduces the boilerplate of doing manual dependency injection in your project. I think Hilt better than dagger, even though it's built with dagger2.

Links

@Mustafashahoud
Copy link
Owner

Hi thanks a lot for your contribution, but I would NOT do this in the master branch if you do it in a different branch it would be great.

@naufalprakoso
Copy link
Author

Thank you for your feedback. It's okay to merge this contribution to other branch, as long as it can benefit many people. Maybe you can create a new branch for this contribution. Thanks 😁

@Mustafashahoud
Copy link
Owner

Hi, I've reviewed the changes, Most of the UI tests are failing due to:
java.lang.RuntimeException: java.lang.IllegalStateException: Hilt Fragments must be attached to an @AndroidEntryPoint Activity. Found: class androidx.fragment.app.testing.FragmentScenario$EmptyFragmentActivity
you can see in Hitl Doc that Hilt does not currently support FragmentScenario, however there is still a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants