Update Harvest to support multi-tenancy and OpenSearch Serverless #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
February 3, 2024 10:53
Cognito needs three values to be consistent. To do this, modified the cognitoCliendId tag to be an extension of the normalizedString then added the two URLs that are needed. In theory, the two URLs do not need to change for an ops service so have them defaulted to something right now and left them as optional. Can and should change these when the real multitenacy goes live. Moved the self signed certificate trust to the server URL since that is whwere it belongs - the registry is not the problem especially with cognito but a standalone server for testing or development can be and probably is.
Should have separated all of the get/search parts and everything that is es or os is now in registry-common.
al-niessner
changed the title
jordanpadams
changed the title
added 2 commits
April 25, 2024 14:57
tloubrieu-jpl
approved these changes
Jun 20, 2024
|
Hi @al-niessner , I approved this PR but it is still in draft status. Is there anything you would like to do before it is merged ? Thomas |
|
No. I was just waiting for other PRs to close before marking this as ready since it depends on them. |
|
Perfect, I approved the pr on registry-common, so we should good in harvest. |
tloubrieu-jpl
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Adapt to latest registry-common. Added part to update index when it finds new ref_lid_* in the document.
⚙️ Test Data and/or Report
TBD
♻️ Related Issues
Closes #118
Closes #127
Closes #156