Implements openDTU (for Hoymiles Micro Inverter) #2566
Conversation
|
@Sn0w3y: Thank you for the effort. Please read and execute the contribution guidelines carefully, especially this: https://openems.github.io/openems.io/openems/latest/contribute/coding-guidelines.html#_openems_edge_backend. |
Thanks Stefan, is there a possibility to check the Build locally so i do not bother you by sending a PR with a Test which makes a red cross ? :D Would be glad to know and i will fix it ASAP |
|
@Sn0w3y: In Eclipse you should always run Checkstyle and all JUnit tests (of your bundle). Afterwards run |
Changed public CompletableFuture<String> request(Endpoint endpoint) so it does not return null as otherwise test failes as excpected..
|
|
|
@sfeilmeier ready for Review i guess :) |
|
|
| } | ||
|
|
||
| switch (event.getTopic()) { | ||
| case EdgeEventConstants.TOPIC_CYCLE_AFTER_PROCESS_IMAGE: |
There was a problem hiding this comment.
I guess that the case will never be reached, as it was not mentioned in the event topics in the class annotations
@EventTopics({ // EdgeEventConstants.TOPIC_CYCLE_BEFORE_PROCESS_IMAGE, // }) public class OpendtuImpl extends AbstractOpenemsComponent implements Opendtu, SinglePhaseMeter, ElectricityMeter, OpenemsComponent, EventHandler, TimedataProvider {
For now you could only react on case TOPIC_CYCLE_BEFORE_PROCESS_IMAGE mentioned in the annotation
| */ | ||
| POWER_LIMIT(Doc.of(OpenemsType.INTEGER)// | ||
| .unit(Unit.PERCENT) // | ||
| .text("The Relative Limit of the max. Power.").accessMode(AccessMode.READ_WRITE)), |
| private volatile Timedata timedata = null; | ||
|
|
||
| private final CalculateEnergyFromPower calculateActualEnergy = new CalculateEnergyFromPower(this, | ||
| ElectricityMeter.ChannelId.ACTIVE_PRODUCTION_ENERGY); |
There was a problem hiding this comment.
Even if there is only Production, you could add CalculateEnergyFromPower with a Channel ACTIVE_CONSUMPTION_ENERGY, but it's not mandatory as it will never increase as long as the inverter is not used for heating the PV-moduls and consume power.
| String serialNumber() default ""; | ||
|
|
||
| @AttributeDefinition(name = "Meter-Type", description = "What is measured by this DTU?") | ||
| MeterType type() default MeterType.PRODUCTION; |
There was a problem hiding this comment.
If it is really only a pv inverter, like i would expect - you do not have to add the meter type in the config as it is always PRODUCTION.
Just set a fixed configuration property like this:
https://github.com/Sn0w3y/openems/blob/26cebce21d45f8f78edc93ed93e2084eb27c2750/io.openems.edge.pvinverter.fronius/src/io/openems/edge/pvinverter/fronius/PvInverterFroniusImpl.java#L44
Maybe you have to take care in the UI separately - i remember a method in the UI Part "isProduction".
Im not completely sure if there is still the need to do something in there.
| @AttributeDefinition(name = "Meter-Type", description = "What is measured by this DTU?") | ||
| MeterType type() default MeterType.PRODUCTION; | ||
|
|
||
| @AttributeDefinition(name = "Initial Power Limit", description = "The initial power limit setting") |
There was a problem hiding this comment.
What is the "power limit" used for?
This PR implements the openDTU (free DTU) dor Hoymiles Micro-Inverters).
The Module uses the API of the openDTU to communicate with the Inverters.
Thanks to @DerWahreKlinki for helping me with it :)