Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration of new component visualization options #168

Merged
merged 13 commits into from
Jun 27, 2024
Merged

Integration of new component visualization options #168

merged 13 commits into from
Jun 27, 2024

Conversation

Eliott-Guevel
Copy link
Collaborator

No description provided.

Eliott Guevel and others added 2 commits February 28, 2024 15:54
Added two new options to Molecule:
2f21bde 
- when selecting a Molecule Type Trait, the Extra submenu now comports a "See component implementations" option which is used to visualize the implementations of the selected Type
- when selecting a Molecule interface, the Extra submenu now comports a "See component users" option which is used to visualize which Type require and/or offer the selected interface (a drop-down list is used to change the boolean operator used between lists)
Right-clicking a Type on the latter option shows the first option so that they can be chained together.
Each element can be double-clicked to be browsed (opens a System Browser on the selected class).
Each list can also be filtered.
@labordep
Merge pull request #166 from Eliott-Guevel/SeeComponentImplementation…
41be08f 
…AndSeeComponentUsers

Adds two new visualization options to Molecule
@labordep labordep self-requested a review March 25, 2024 10:21
@labordep labordep added the enhancement New feature or request label Mar 25, 2024
labordep
labordep requested changes Mar 25, 2024
View reviewed changes
src/Molecule-IDE/MolWorld.class.st Outdated Show resolved Hide resolved
@Eliott-Guevel Eliott-Guevel mentioned this pull request Mar 25, 2024
Merged
@labordep labordep self-requested a review March 25, 2024 11:10
@labordep
Copy link
Member

@Eliott-Guevel I found a problem in this panel:
image

From the state of the screenshot (two selected elements):
1 - I click on "Browse" the class Equipment is browsed.
2 - I click on Receiver in the required list, and I click on "Browse" the class Equipment is always browsed

labordep
labordep requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@labordep labordep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my bug report in PR comment.

@Eliott-Guevel Eliott-Guevel mentioned this pull request Mar 27, 2024
Merged
@Eliott-Guevel
Copy link
Collaborator Author

see #172 for a fix

Eliott Guevel and others added 2 commits March 27, 2024 09:32
removed flag
216fff5
@labordep
Merge pull request #172 from Eliott-Guevel/SeeComponentImplementation…
fd1da6b 
…AndSeeComponentUsers

Integration of 2 new visualization options
labordep
labordep requested changes Mar 28, 2024
View reviewed changes
Copy link
Member

@labordep labordep left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eliott-Guevel, thanks. I wrote some comments and resquest changes.

src/Molecule-IDE-Tests/MyClass.class.st Outdated Show resolved Hide resolved
src/Molecule-IDE/MolOptions.class.st Outdated Show resolved Hide resolved
src/Molecule-IDE/MolUtils.extension.st Outdated Show resolved Hide resolved
src/Molecule-IDE/SpFilteringListDoubleClickPresenter.class.st Outdated Show resolved Hide resolved
@Eliott-Guevel Eliott-Guevel mentioned this pull request Mar 28, 2024
Merged
labordep
labordep requested changes Apr 2, 2024
View reviewed changes
src/Molecule-IDE/MolImplementations.class.st Outdated Show resolved Hide resolved
src/Molecule-IDE-Tests/MolImplementationsTest.class.st Outdated Show resolved Hide resolved
src/Molecule-IDE/MolInterfaces.class.st Outdated Show resolved Hide resolved
src/Molecule-IDE-Tests/MolInterfacesTest.class.st Outdated Show resolved Hide resolved
@Eliott-Guevel Eliott-Guevel mentioned this pull request Apr 2, 2024
Merged
@labordep
Merge pull request #174 from Eliott-Guevel/SeeComponentImplementation…
53b1f8c 
…AndSeeComponentUsers

Suffixed (test) classes with Presenter
@labordep
Copy link
Member

labordep commented Jun 14, 2024 •
edited
Loading

Hi @Eliott-Guevel why this PR is not yet merged?

@Eliott-Guevel
Copy link
Collaborator Author

image
I don't know if GitHub also shows you this message, but I fixed my code according to your comments so you can merge this pull request since the interfaces function as intended and are named correctly. Thanks

@labordep
Copy link
Member

Hi @Eliott-Guevel, the PR #177 is now merged. This PR contains new components start/stop announcement system. You can test your dev with it. Some tests for P12 are not passing, please check that (ignore P13 tests). Thanks!

@Eliott-Guevel
Copy link
Collaborator Author

Eliott-Guevel commented Jun 26, 2024 •
edited
Loading

There are no problems with my interfaces using the new main branch with #177 merged.

However, I don't understand why some of MolComponentManager's tests fail sometimes. When executing all of MolComponentManager's tests at the same time, 3 (or less) tests can fail (always the same ones, see Pharo 12 CI as well as testGarbageCollect (don't know why testFlushComponent is executed 2 times), which is not the case when executing them individually.
Putting relevant variables and going line by line in the debugger isn't useful to identify the fail (doesn't lead to the same result).
My guess is that since the order of tests is random, there's sometimes a bug with cleanUp and not all components are cleaned or something of the sort (and ONLY in Pharo 12, so could abso be a problem with the VM which apparently it is not, see pharo-project/pharo#16808 (comment)).

@labordep labordep changed the title Integration of new visualization options Integration of new component visualization options Jun 27, 2024
@labordep labordep merged commit f48815a into main Jun 27, 2024
6 of 9 checks passed
@labordep labordep deleted the dev-incubator branch June 27, 2024 14:07
@Eliott-Guevel Eliott-Guevel mentioned this pull request Jun 27, 2024
Merged
@Eliott-Guevel
Copy link
Collaborator Author

I have no problem using the visualization option (which isn't currently intergrated to Molecule) with #177, it could be merged in the near future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labordep labordep labordep requested changes

Assignees

@Eliott-Guevel Eliott-Guevel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Eliott-Guevel @labordep