Mapping for advancements and client packages
#288
+189
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sciwhiz12
reviewed
Jul 6, 2024
| @@ -34,8 +34,8 @@ CLASS net/minecraft/client/renderer/LevelRenderer | |||
| ARG 10 blue | |||
| ARG 11 alpha | |||
| METHOD addFrustumQuad (Lcom/mojang/blaze3d/vertex/VertexConsumer;Lorg/joml/Matrix4f;IIIIIII)V | |||
| ARG 1 consumer | |||
| ARG 2 matrix | |||
| ARG 1 buffer | |||
There was a problem hiding this comment.
Why the change from consumer to buffer in these methods, since the type is VertexConsumer?
There was a problem hiding this comment.
buffer is more correct. The VertexConsumer is always sourced from MultiBufferSource.getBuffer() and represents a buffer.
Comment on lines
+6
to
+7
| ARG 0 pose | ||
| ARG 1 buffer |
There was a problem hiding this comment.
RE: Why the change from consumer to buffer for type VertexConsumer?
There was a problem hiding this comment.
buffer is more correct. The VertexConsumer is always sourced from MultiBufferSource.getBuffer() and represents a buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.