Merge pull request #445 from Privado-Inc/dev

fix: correct sdk sink names for third parties (#443)
Privado-Inc · Apr 10, 2024 · ed55b55 · ed55b55
2 parents d7e6331 + 674b63b
commit ed55b55
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/rules/sinks/third_parties/sdk/amazon/csharp.yaml b/rules/sinks/third_parties/sdk/amazon/csharp.yaml
@@ -45,7 +45,7 @@ sinks:
     tags:
 
   - id: ThirdParties.SDK.Amazonaws.Kinesis
-    name: Amazon Aws Kinesis
+    name: Amazon AWS Kinesis
     domains:
       - "aws.amazon.com/kinesis/"
     patterns:

diff --git a/rules/sinks/third_parties/sdk/amazon/javascript.yaml b/rules/sinks/third_parties/sdk/amazon/javascript.yaml
@@ -138,7 +138,7 @@ sinks:
   - id: ThirdParties.SDK.Amazonaws.Auth
     name: Amazonaws Auth
     domains:
-      - "aws.amazon.com"
+      - "docs.aws.amazon.com/prescriptive-guidance/latest/modernization-net-applications-security/authentication.html"
     patterns:
       - "(?i)(react-oauth2-pkce|@cloudcomponents\\/cdk-cloudfront-authorization|@vue-toolkit\\/aws-auth|react-oauth2-pkce-temp|passwordless-auth|serverless-custom-auth-plugin|brewery-auth|graphql-workspace-authorizer-transformer|vault-auth-aws|aws-api-auth-policy|@pi-team-mn\\/aws-apigw-authorizer|awsauth|redis-connection-no-auth|@stinkstudios\\/cf-auth|api-gateway-auth-policy|@orcden\\/od-authentication|aws-apigw-authorizer|@engineal\\/aws-cdk-recaptcha-authorizer)"
     tags:

diff --git a/rules/sinks/third_parties/sdk/amazon/python.yaml b/rules/sinks/third_parties/sdk/amazon/python.yaml
@@ -799,7 +799,7 @@ sinks:
     tags:
 
   - id: ThirdParties.SDK.Amazon.Aws
-    name: Amazon AWS
+    name: Amazon Aws
     domains:
       - "aws.amazon.com"
     patterns:

diff --git a/rules/sinks/third_parties/sdk/amazonaws/java.yaml b/rules/sinks/third_parties/sdk/amazonaws/java.yaml
@@ -1359,7 +1359,7 @@ sinks:
   - id: ThirdParties.SDK.Amazonaws.AppRegistry
     name: Amazonaws App Registry
     domains:
-      - "aws.amazon.com"
+      - "docs.aws.amazon.com/servicecatalog/latest/arguide/intro-app-registry.html"
     patterns:
       - "(?i)(com[.]amazonaws[.]services[.]appregistry).*"
     tags:

diff --git a/rules/sinks/third_parties/sdk/google/javascript.yaml b/rules/sinks/third_parties/sdk/google/javascript.yaml
@@ -39,7 +39,7 @@ sinks:
   - id: ThirdParties.SDK.Google.TagManager
     name: Google Tag Manager
     domains:
-      - "analytics.google.com"
+      - "tagmanager.google.com"
     patterns:
       - "@analytics\\/google-tag-manager|gatsby-plugin-google-gtag|react-gtm-module"
     tags:
@@ -48,7 +48,7 @@ sinks:
     name: Google Tag Manager
     filterProperty: "code"
     domains:
-      - "analytics.google.com"
+      - "tagmanager.google.com"
     patterns:
       - "(?i)(.*[.])?(gtag|dataLayer.push)[(].*"
     tags:

diff --git a/rules/sinks/third_parties/sdk/google/php.yaml b/rules/sinks/third_parties/sdk/google/php.yaml
@@ -57,7 +57,7 @@ sinks:
   - id: ThirdParties.SDK.Google.TagManager
     name: Google Tag Manager
     domains:
-      - "analytics.google.com"
+      - "tagmanager.google.com"
     patterns:
       - "(?i).*(googletagmanager).*"
     tags: