`Paywalls`: extracted `PurchaseButton` #2839

NachoSoto · 2023-07-19T00:43:34Z

Another small refactor, follow up to #2837.
Slowly taking implementation details from Example1Template to make it easier to implement more templates.

NachoSoto · 2023-07-19T00:44:12Z

RevenueCatUI/Views/AsyncButton.swift

@@ -11,7 +11,7 @@ import SwiftUI
 @available(iOS 16.0, macOS 13.0, tvOS 16.0, *)
 struct AsyncButton<Label>: View where Label: View {

-    typealias Action = @Sendable () async throws -> Void
+    typealias Action = @Sendable @MainActor () async throws -> Void


This ensures that the action is always @MainActor so usages don't have to make it explicit.

RevenueCatUI/Views/PurchaseButton.swift

NachoSoto · 2023-07-19T00:44:40Z

RevenueCatUI/Views/PurchaseButton.swift

+                if case .fullScreen = self.mode {
+                    self.dismiss()
+                } else {
+                    self.purchased = true
+                }


@aboedo you mentioned handling this for not-fullscreen paywalls.

RevenueCatUI/Views/PurchaseButton.swift

NachoSoto · 2023-07-19T00:45:25Z

RevenueCatUI/Views/PurchaseButton.swift

+
+    static var previews: some View {
+        ForEach(PaywallViewMode.allCases, id: \.self) { mode in
+            Preview(mode: mode)


Having small previewable views makes it easy to iterate on each small component.

NachoSoto · 2023-07-20T08:29:01Z

RevenueCatUI/PaywallView.swift

+    private var shouldHidePaywall: Bool {
+        switch self.mode {
+        case .fullScreen:
+            return false
+
+        case .card, .banner:
+            return self.purchaseHandler.purchased
+        }
+    }
+


@aboedo this looks pretty good for now :) and it gets animated.

wonder if we should even consider making that variable public so that you can use it in the app

NachoSoto · 2023-07-20T16:24:34Z

RevenueCatUI/Data/TestData.swift

-        return .init { [purchaseBlock = self.purchaseBlock] in
-            try? await Task.sleep(for: delay)
+        return self.map { purchaseBlock in {
+                try? await Task.sleep(for: delay)

-            return try await purchaseBlock($0)
+                return try await purchaseBlock($0)
+            }
        }


Small refactor because I made the block private.

aboedo

left a few comments, looks good overall

aboedo · 2023-07-20T20:29:12Z

RevenueCatUI/PaywallView.swift

+    private var shouldHidePaywall: Bool {
+        switch self.mode {
+        case .fullScreen:
+            return false
+
+        case .card, .banner:
+            return self.purchaseHandler.purchased
+        }
+    }
+


wonder if we should even consider making that variable public so that you can use it in the app

aboedo · 2023-07-20T20:30:09Z

RevenueCatUI/Purchasing/PurchaseHandler.swift

+        if !result.userCancelled {
+            withAnimation(Constants.defaultAnimation) {
+                self.purchased = true
+            }
+        }


I love that even this bit is something that we're handling now

aboedo · 2023-07-20T20:32:59Z

RevenueCatUI/Views/PurchaseButton.swift

+                self.dismiss()
+            }
+        } label: {
+            IntroEligibilityStateView(


Feels like this could be more appropriately named something like CTAText view

Yeah it's a bad name, but it's not just for the CTA.
From the docstring:

/// A view that can process intro eligibility and display different data based on the result.

It's used for CTA but also for other labels. It's just a label that uses a loading intro eligibility and then decides what to display. Better name suggestions welcome.

Actually that's what you approved: #2837
I'll hold on in case you have a suggestion for a better name though.

Merging this, but let me know if you can think of a better name.

aboedo · 2023-07-20T20:34:18Z

RevenueCatUI/Views/PurchaseButton.swift

+        .buttonBorderShape(self.mode.buttonBorderShape)
+        .controlSize(self.mode.buttonSize)
+        .buttonStyle(.borderedProminent)
+        .frame(maxWidth: .infinity)


feels somewhat confusing that self.mode.fullWidthButton doesn't refer to this width but rather the one for the button's label

That's just an implementation detail for how SwiftUI's layout works.

aboedo · 2023-07-20T20:35:07Z

RevenueCatUI/Views/PurchaseButton.swift

+    var buttonFont: Font {
+        switch self {
+        case .fullScreen, .card: return .title2
+        case .banner: return .footnote
+        }
+    }


how do you envision this scaling to different templates?

Probably would need to inject this font to PurchaseButton instead.

RevenueCatUI/Helpers/ColorInformation+MultiScheme.swift

joshdholtz · 2023-07-21T02:27:25Z

RevenueCatUI/Data/TestData.swift

+    #if canImport(SwiftUI) && canImport(UIKit)
+    static let colors: PaywallData.Configuration.Colors = .comine(light: Self.lightColors, dark: Self.darkColors)
+    #endif


What happens here if these aren't supported? 🤔

The views don’t support it either. But when/if we do, the compiler will fail. So it’ll force us to use something else (in practice we’ll expose an NSColor for example).

RevenueCatUI/Helpers/ColorInformation+MultiScheme.swift

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

@NachoSoto

**This is an automatic release.** ### New Features #### ✨ Introducing RevenueCatUI 📱 RevenueCat's Paywalls allow you to to remotely configure your entire paywall view without any code changes or app updates. Our paywall templates use native code to deliver smooth, intuitive experiences to your customers when you’re ready to deliver them an Offering; and you can use our Dashboard to pick the right template and configuration to meet your needs. To use RevenueCat Paywalls on iOS, simply: 1. Create a Paywall on the Dashboard for the `Offering` you intend to serve to your customers 2. Add the `RevenueCatUI` SPM dependency to your project 3. `import RevenueCatUI` at the point in the user experience when you want to display a paywall: ```swift import RevenueCatUI import SwiftUI struct YourApp: View { var body: some View { YourContent() .presentPaywallIfNeeded( requiredEntitlementIdentifier: "pro", purchaseCompleted: { customerInfo in print("Purchase completed: \(customerInfo)") }, restoreCompleted: { customerInfo in print("Purchases restored: \(customerInfo)") } ) } } ``` You can find more information in [our documentation](https://rev.cat/paywalls). <details> <summary>List of changes</summary> * NachoSoto: `Paywalls`: renamed `PaywallEvent.view` to `.impression` (#3212) * NachoSoto: `Paywalls`: loading indicator for in-progress purchases (#3217) * NachoSoto: `Paywalls`: fixed template 4 bottom padding (#3211) * NachoSoto: `Paywalls`: only pre-warm images/intro-eligibility for `Offerings.current` (#3210) * NachoSoto: `Paywalls`: fixed mock intro eligibility on snapshot tests (#3205) * NachoSoto: `Paywalls`: fixed SimpleApp release build (#3203) * NachoSoto: `Paywalls`: improved `DebugErrorView` layout (#3204) * NachoSoto: `Paywalls`: refactored `PurchaseHandler` extracting protocol (#3196) * NachoSoto: `Paywalls`: automatically flush events (#3177) * NachoSoto: `Paywalls`: fixed `TemplateBackgroundImageView` aspect ratio (#3201) * NachoSoto: `Paywalls`: fixed broken layout on template 4 (#3202) * NachoSoto: `Paywalls`: events unit and integration tests (#3169) * NachoSoto: `Paywalls`: send events to `Purchases` (#3164) * NachoSoto: `Paywalls`: convert empty images into `nil` (#3195) * NachoSoto: `Paywalls`: new `onRestoreCompleted` handler (#3190) * NachoSoto: `Paywalls`: fixed `IntroEligibilityViewModel` data lifetime (#3194) * NachoSoto: `Paywalls`: test plan for running non-snapshot tests (#3188) * NachoSoto: `Paywalls`: polish template 4 (#3183) * NachoSoto: `Paywalls`: fixed data flow resulting in multiple `PurchaseHandler` instances (#3187) * Cesar de la Vega: `Paywalls`: update `blurred_background_image` key in `PaywallData` test fixture (#3186) * NachoSoto: `Paywalls`: added `Purchases.track(paywallEvent:)` (#3160) * NachoSoto: `Paywalls`: don't apply dark appearance with no dark mode colors (#3184) * NachoSoto: `Paywalls`: fixed template 2 + `.condensedFooter` + iPad (#3185) * NachoSoto: `Paywalls`: new `{{ sub_duration_in_months }}` variable (#3173) * NachoSoto: `Paywalls`: created `PaywallEventsManager` (#3159) * NachoSoto: `Paywalls`: implemented `PostPaywallEventsOperation` (#3158) * NachoSoto: `Paywalls`: new `{{ sub_relative_discount }}` variable (#3131) * Charlie Chapman: `Paywalls`: improved `FooterView` (#3171) * NachoSoto: `Paywalls`: fixed `FooterView` horizontal centering (#3172) * NachoSoto: `Paywalls`: created `PaywallEventStore` (#3157) * NachoSoto: `Paywalls`: add `PaywallEvent` model (#3156) * NachoSoto: `Paywalls`: add `PaywallData.revision` (#3155) * NachoSoto: `Paywalls`: support fuzzy-Locale search in `iOS 15` (#3162) * NachoSoto: `PaywallData`: added `@NonEmptyString` to `subtitle` and `offerName` (#3150) * NachoSoto: `Paywalls`: add paywall for Load Shedder integration tests (#3151) * NachoSoto: `Paywalls`: fixed error view being displayed on release builds (#3141) * NachoSoto: `Paywalls`: improved `{{ total_price_and_per_month }}` to include period (#3136) * NachoSoto: `Paywalls`: `{{ price_per_period }}` now takes `SubscriptionPeriod.value` into account (#3133) * NachoSoto: `Paywalls`: add Arabic to SimpleApp for testing (#3132) * NachoSoto: `Paywalls`: update snapshot generation with new separate git repo (#3116) * NachoSoto: `Paywalls`: add support for CTA button gradients (#3121) * NachoSoto: `Paywalls`: template 5 (#3095) * NachoSoto: `Paywalls`: replaced submodule with `gitignore`d reference (#3125) * NachoSoto: `Catalyst`: fixed a couple of Catalyst build warnings (#3120) * NachoSoto: `Paywalls`: reference test snapshots from submodule (#3115) * NachoSoto: `Paywalls`: removed `presentedPaywallViewMode` (#3109) * NachoSoto: `Paywalls`: remove duplicate `RevenueCat` scheme to fix Carthage (#3105) * NachoSoto: `Paywalls`: fixed iOS 12 build (#3104) * NachoSoto: `Paywalls`: fixed template 2 inconsistent spacing (#3091) * NachoSoto: `Paywalls`: improved test custom paywall (#3089) * NachoSoto: `Paywalls`: avoid warming up cache multiple times (#3068) * NachoSoto: `Paywalls`: added all localization (#3080) * NachoSoto: `Paywalls`: temporarily disable `PaywallTemplate.template4` (#3088) * NachoSoto: `Paywalls`: enabled `Catalyst` support (#3087) * NachoSoto: `Paywalls`: iPad polish (#3061) * NachoSoto: `Paywalls`: added MIT license to all headers (#3084) * NachoSoto: `Paywalls`: improved unselected package background color (#3079) * NachoSoto: `Paywalls`: handle already purchased state (#3046) * NachoSoto: `Paywalls`: only dismiss `PaywallView` when explicitly presenting it with `.presentPaywallIfNeeded` (#3075) * NachoSoto: `Paywalls`: add support for generating snapshots on CI (#3055) * NachoSoto: `Paywalls`: removed unnecessary `PaywallFooterView` (#3064) * Josh Holtz: `Paywalls`: new `PaywallFooterView` to replace `modes` (#3051) * Josh Holtz: `Paywalls`: rename card to footer (#3049) * NachoSoto: `Paywalls`: changed `total_price_and_per_month` to include period (#3044) * NachoSoto: `Paywalls`: internal documentation for implementing templates (#3053) * NachoSoto: `Paywalls`: finished `iOS 15` support (#3043) * NachoSoto: `Paywalls`: validate `PaywallData` to ensure displayed data is always correct (#3019) * NachoSoto: `Paywalls`: fixed `total_price_and_per_month` for custom monthly packages (#3027) * NachoSoto: `Paywalls`: tweaking colors on template 2&3 (#3011) * NachoSoto: `Paywalls`: changed snapshots to scale 1 (#3016) * NachoSoto: `Paywalls`: replaced `defaultLocale` with `preferredLocales` (#3003) * NachoSoto: `Paywalls`: improved `PaywallDisplayMode.condensedCard` layout (#3001) * NachoSoto: `Paywalls`: `.card` and `.condensedCard` modes (#2995) * NachoSoto: `Paywalls`: prevent multiple concurrent purchases (#2991) * NachoSoto: `Paywalls`: improved variable warning (#2984) * NachoSoto: `Paywalls`: fixed horizontal padding on template 1 (#2987) * NachoSoto: `Paywalls`: changed `FooterView` to always use `text1` color (#2992) * NachoSoto: `Paywalls`: retry test failures (#2985) * NachoSoto: `Paywalls`: send presented `PaywallViewMode` with purchases (#2859) * NachoSoto: `Paywalls`: added support for custom fonts (#2988) * NachoSoto: `Paywalls`: improved template 2 unselected packages (#2982) * Josh Holtz: `Paywalls`: fix template 2 selected text offer details color (#2975) * NachoSoto: `Paywalls`: warm-up image cache (#2978) * NachoSoto: `Paywalls`: extracted `PaywallCacheWarming` (#2977) * NachoSoto: `Paywalls`: fixed color in template 3 (#2980) * NachoSoto: `Paywalls`: improved default template (#2973) * NachoSoto: `Paywalls`: added links to documentation (#2974) * NachoSoto: `Paywalls`: updated template names (#2971) * NachoSoto: `Paywalls`: updated variable names (#2970) * NachoSoto: `Paywalls`: added JSON debug screen to `debugRevenueCatOverlay` (#2972) * NachoSoto: `Paywalls`: multi-package horizontal template (#2949) * NachoSoto: `Paywalls`: fixed template 3 icon aspect ratio (#2969) * NachoSoto: `Paywalls`: iOS 17 tests on CI (#2955) * NachoSoto: `Paywalls`: deploy `debug` sample app (#2966) * NachoSoto: `Paywalls`: sort offerings list in sample app (#2965) * NachoSoto: `Paywalls`: initial iOS 15 support (#2933) * NachoSoto: `Paywalls`: changed default `PaywallData` to display available packages (#2964) * NachoSoto: `Paywalls`: changed `offerDetails` to be optional (#2963) * NachoSoto: `Paywalls`: markdown support (#2961) * NachoSoto: `Paywalls`: updated icon set to match frontend (#2962) * NachoSoto: `Paywalls`: added support for `PackageType.custom` (#2959) * NachoSoto: `Paywalls`: fixed `tvOS` compilation by making it explicitly unavailable (#2956) * NachoSoto: `Paywalls`: fix crash when computing localization with duplicate packages (#2958) * NachoSoto: `Paywalls`: UIKit `PaywallViewController` (#2934) * NachoSoto: `Paywalls`: `presentPaywallIfNecessary` -> `presentPaywallIfNeeded` (#2953) * NachoSoto: `Paywalls`: added support for custom and lifetime products (#2941) * NachoSoto: `Paywalls`: changed `SamplePaywallsList` to work offline (#2937) * NachoSoto: `Paywalls`: fixed header image mask on first template (#2936) * NachoSoto: `Paywalls`: new `subscription_duration` variable (#2942) * NachoSoto: `Paywalls`: removed `mode` parameter from `presentPaywallIfNecessary` (#2940) * NachoSoto: `Paywalls`: improved `RemoteImage` error layout (#2939) * NachoSoto: `Paywalls`: added default close button when using `presentPaywallIfNecessary` (#2935) * NachoSoto: `Paywalls`: added ability to preview templates in a `.sheet` (#2938) * NachoSoto: `Paywalls`: avoid recomputing variable `Regex` (#2944) * NachoSoto: `Paywalls`: improved `FooterView` scaling (#2948) * NachoSoto: `Paywalls`: added ability to calculate and localize subscription discounts (#2943) * NachoSoto: `Offering`: improved description (#2912) * NachoSoto: `Paywalls`: fixed `FooterView` color in template 1 (#2951) * NachoSoto: `Paywalls`: fixed `View.scrollableIfNecessary` (#2947) * NachoSoto: `Paywalls`: improved `IntroEligibilityStateView` to avoid layout changes (#2946) * NachoSoto: `Paywalls`: updated offerings snapshot with new asset base URL (#2950) * NachoSoto: `Paywalls`: extracted `TemplateBackgroundImageView` (#2945) * NachoSoto: `Paywalls`: more polish from design feedback (#2932) * NachoSoto: `Paywalls`: more unit tests for purchasing state (#2931) * NachoSoto: `Paywalls`: new `.onPurchaseCompleted` modifier (#2930) * NachoSoto: `Paywalls`: fixed `LoadingPaywallView` displaying a progress view (#2929) * NachoSoto: `Paywalls`: added default template to `SamplePaywallsList` (#2928) * NachoSoto: `Paywalls`: added a few more logs (#2927) * NachoSoto: `Paywalls` added individual previews for templates (#2924) * NachoSoto: `Paywalls`: improved default paywall configuration (#2926) * NachoSoto: `Paywalls`: moved purchasing state to `PurchaseHandler` (#2923) * NachoSoto: `Paywalls`: updated Integration Test snapshot (#2921) * NachoSoto: `Paywalls`: pre-warm intro eligibility in background thread (#2925) * NachoSoto: `Paywalls`: removed "couldn't find package" log (#2922) * NachoSoto: `Paywalls`: SimpleApp reads API key from Xcode Cloud environment (#2919) * NachoSoto: `Paywalls`: improved template accessibility support (#2920) * NachoSoto: `Paywalls`: work around SwiftUI bug to allow embedding `PaywallView` inside `NavigationStack` (#2918) * NachoSoto: `Paywalls`: some basic polish from design feedback (#2917) * NachoSoto: `Paywalls`: added `OfferingsList` to preview all paywalls (#2916) * NachoSoto: `Paywalls`: fixed tappable area for a couple of buttons (#2915) * NachoSoto: `Paywalls`: new `text1` and `text2` colors (#2903) * NachoSoto: `Paywalls`: updated multi-package bold template design (#2908) * NachoSoto: `Paywalls`: added sample paywalls to `SimpleApp` (#2907) * NachoSoto: `Paywalls`: one package with features template (#2902) * NachoSoto: `Paywalls`: initial support for icons (#2882) * NachoSoto: `Paywalls`: extracted intro eligibility out of templates (#2901) * NachoSoto: `Paywalls`: changed `subtitle` to be optional (#2900) * NachoSoto: `Paywalls`: added "features" to `LocalizedConfiguration` (#2899) * NachoSoto: `Paywalls`: fixed `{{ total_price_and_per_month }}` (#2881) * NachoSoto: `Paywalls`: updated template names (#2878) * NachoSoto: `Paywalls`: added accent colors (#2883) * NachoSoto: `Paywalls`: changed images representation to an object (#2875) * NachoSoto: `Paywalls`: added `offerName` parameter (#2877) * NachoSoto: `Paywalls`: new `{{ period }}` variable (#2876) * NachoSoto: `Paywalls`: disabled `PaywallViewMode`s for now (#2874) * NachoSoto: `Paywalls`: added new `defaultPackage` configuration (#2871) * NachoSoto: `Paywalls`: fixed tests on CI (#2872) * NachoSoto: `Paywalls`: pre-fetch intro eligibility for paywalls (#2860) * Andy Boedo: `Paywalls`: clean up the error view (#2873) * NachoSoto: `Paywalls`: new API for easily displaying `PaywallView` with just one line (#2869) * NachoSoto: `Paywalls`: handle missing paywalls gracefully (#2855) * NachoSoto: `Paywalls`: temporarily disable non-fullscreen `PaywallView`s (#2868) * NachoSoto: `Paywalls`: added test to ensure package selection maintains order (#2853) * NachoSoto: `Paywalls`: added new `blurredBackgroundImage` configuration (#2852) * NachoSoto: `Paywalls`: fuzzy `Locale` lookups (#2847) * NachoSoto: `Paywalls`: basic localization support (#2851) * NachoSoto: `Paywalls`: added `FooterView` (#2850) * NachoSoto: `Paywalls`: multi-package template (#2840) * NachoSoto: `Paywalls`: disable animations during unit tests (#2848) * NachoSoto: `Paywalls`: `TrialOrIntroEligibilityChecker.eligibility(for packages:)` (#2846) * NachoSoto: `Paywalls`: added new `total_price_and_per_month` variable (#2845) * NachoSoto: `Paywalls`: extracted `PurchaseButton` (#2839) * NachoSoto: `Paywalls`: extracted `IntroEligibilityStateView` (#2837) * NachoSoto: `Paywalls`: support for multiple `PaywallViewMode`s (#2834) * NachoSoto: `Paywalls`: add support for multiple images in template configuration (#2832) * NachoSoto: `Paywalls`: extracted configuration processing into a new `TemplateViewConfiguration` (#2830) * NachoSoto: `Paywalls`: improved support for dynamic type with snapshots (#2827) * NachoSoto: `Paywalls`: disable `macOS`/`macCatalyst`/`watchOS` for now (#2821) * NachoSoto: `Paywalls`: using new color information in template (#2823) * NachoSoto: `Paywalls`: set up CI tests and API Tester (#2816) * NachoSoto: `Paywalls`: added support for decoding colors (#2822) * NachoSoto: `Paywalls`: ignore empty strings in `LocalizedConfiguration` (#2818) * NachoSoto: `Paywalls`: updated `PaywallData` field names (#2817) * NachoSoto: `Paywalls`: added support for purchasing (#2812) * NachoSoto: `Paywalls`: added tests for `PackageType` filtering (#2810) * Andy Boedo: `Paywalls`: changed variable handling to use Swift `Regex` (#2811) * NachoSoto: `Paywalls`: added `price` variable (#2809) * NachoSoto: `Paywalls`: determine intro eligibility (#2808) * NachoSoto: `Paywalls`: added header image to configuration (#2800) * NachoSoto: `Paywalls`: added `packages` to configuration (#2798) * NachoSoto: `Paywalls`: add support for displaying `StoreProductDiscount`s (#2796) * NachoSoto: `Paywalls`: added support for variables (#2793) * NachoSoto: `Paywalls`: using `PaywallData` and setting up basic template loading (#2781) * NachoSoto: `Paywalls`: initial configuration types (#2780) * NachoSoto: `Paywalls`: initial `RevenueCatUI` target setup (#2776) </details> ### Other Changes * `Debug`: add `Offering` metadata to debug screen (#3137) via NachoSoto (@NachoSoto) * `TestStoreProduct`: new `locale` parameter (#3134) via NachoSoto (@NachoSoto) * `Integration Tests`: fixed more flaky failures (#3218) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com> Co-authored-by: NachoSoto <NachoSoto@users.noreply.github.com>

NachoSoto added refactor A code change that neither fixes a bug nor adds a feature RevenueCatUI labels Jul 19, 2023

NachoSoto requested a review from a team July 19, 2023 00:43

NachoSoto commented Jul 19, 2023

View reviewed changes

RevenueCatUI/Views/PurchaseButton.swift Outdated Show resolved Hide resolved

NachoSoto commented Jul 19, 2023

View reviewed changes

RevenueCatUI/Views/PurchaseButton.swift Outdated Show resolved Hide resolved

NachoSoto commented Jul 19, 2023

View reviewed changes

NachoSoto force-pushed the paywalls-purchase-button branch from b2130e9 to c9ffa05 Compare July 19, 2023 14:50

NachoSoto commented Jul 20, 2023

View reviewed changes

NachoSoto force-pushed the paywalls-intro-state-view branch from 5da7bc7 to ad32f43 Compare July 20, 2023 11:27

NachoSoto force-pushed the paywalls-purchase-button branch 2 times, most recently from 65e259b to a1006f2 Compare July 20, 2023 11:54

NachoSoto commented Jul 20, 2023

View reviewed changes

aboedo approved these changes Jul 20, 2023

View reviewed changes

joshdholtz approved these changes Jul 21, 2023

View reviewed changes

Base automatically changed from paywalls-intro-state-view to paywalls July 21, 2023 04:46

NachoSoto added 3 commits July 21, 2023 06:47

Paywalls: extracted PurchaseButton

5632742

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

Improved purchase behavior

d900cc3

Typo

f5be1c3

NachoSoto force-pushed the paywalls-purchase-button branch from a1006f2 to f5be1c3 Compare July 21, 2023 04:49

NachoSoto merged commit 3deeb07 into paywalls Jul 21, 2023
3 of 13 checks passed

NachoSoto deleted the paywalls-purchase-button branch July 21, 2023 04:51

NachoSoto added a commit that referenced this pull request Jul 23, 2023

Paywalls: extracted PurchaseButton (#2839)

3236342

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Jul 24, 2023

Paywalls: extracted PurchaseButton (#2839)

55cf1d5

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Jul 24, 2023

Paywalls: extracted PurchaseButton (#2839)

52fb376

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Jul 25, 2023

Paywalls: extracted PurchaseButton (#2839)

2767b96

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Jul 26, 2023

Paywalls: extracted PurchaseButton (#2839)

0488228

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto mentioned this pull request Jul 27, 2023

Paywalls: one package with features template #2902

Merged

NachoSoto added a commit that referenced this pull request Jul 27, 2023

Paywalls: extracted PurchaseButton (#2839)

dc0466c

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Jul 31, 2023

Paywalls: extracted PurchaseButton (#2839)

0d59ce6

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Aug 3, 2023

Paywalls: extracted PurchaseButton (#2839)

988e42a

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Aug 7, 2023

Paywalls: extracted PurchaseButton (#2839)

fd45e3c

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Aug 9, 2023

Paywalls: extracted PurchaseButton (#2839)

b5d826b

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Aug 11, 2023

Paywalls: extracted PurchaseButton (#2839)

cd6af40

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Aug 14, 2023

Paywalls: extracted PurchaseButton (#2839)

c797fff

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Aug 17, 2023

Paywalls: extracted PurchaseButton (#2839)

1f349d2

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Aug 24, 2023

Paywalls: extracted PurchaseButton (#2839)

258cac3

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto mentioned this pull request Aug 26, 2023

[DO NOT MERGE] Release/4.26.0-beta.1 #3102

Closed

NachoSoto added a commit that referenced this pull request Aug 28, 2023

Paywalls: extracted PurchaseButton (#2839)

dbad5ca

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto mentioned this pull request Aug 31, 2023

[DO NOT MERGE] Release/4.26.0-beta.2 #3127

Closed

NachoSoto added a commit that referenced this pull request Aug 31, 2023

Paywalls: extracted PurchaseButton (#2839)

f7507fd

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Sep 1, 2023

Paywalls: extracted PurchaseButton (#2839)

9872876

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Sep 6, 2023

Paywalls: extracted PurchaseButton (#2839)

9adf343

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Sep 6, 2023

Paywalls: extracted PurchaseButton (#2839)

5c4df70

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Sep 6, 2023

Paywalls: extracted PurchaseButton (#2839)

48709f9

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Sep 7, 2023

Paywalls: extracted PurchaseButton (#2839)

3b30e46

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Sep 8, 2023

Paywalls: extracted PurchaseButton (#2839)

cf98c2a

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Sep 14, 2023

Paywalls: extracted PurchaseButton (#2839)

068e1d1

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Sep 14, 2023

Paywalls: extracted PurchaseButton (#2839)

9dd3129

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto added a commit that referenced this pull request Sep 15, 2023

Paywalls: extracted PurchaseButton (#2839)

6e26b7e

Another small refactor, follow up to #2837. Slowly taking implementation details from `Example1Template` to make it easier to implement more templates.

NachoSoto mentioned this pull request Sep 15, 2023

[AUTOMATIC] Release/4.26.0 #3219

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`Paywalls`: extracted `PurchaseButton` #2839

`Paywalls`: extracted `PurchaseButton` #2839

NachoSoto commented Jul 19, 2023

NachoSoto Jul 19, 2023

NachoSoto Jul 19, 2023

NachoSoto Jul 19, 2023

NachoSoto Jul 20, 2023

aboedo Jul 20, 2023

NachoSoto Jul 20, 2023

aboedo left a comment

aboedo Jul 20, 2023

aboedo Jul 20, 2023

aboedo Jul 20, 2023

NachoSoto Jul 20, 2023

NachoSoto Jul 20, 2023

NachoSoto Jul 21, 2023

aboedo Jul 20, 2023

NachoSoto Jul 21, 2023

aboedo Jul 20, 2023

NachoSoto Jul 20, 2023

joshdholtz Jul 21, 2023

NachoSoto Jul 21, 2023

Paywalls: extracted PurchaseButton #2839

Paywalls: extracted PurchaseButton #2839

Conversation

NachoSoto commented Jul 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aboedo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

`Paywalls`: extracted `PurchaseButton` #2839

`Paywalls`: extracted `PurchaseButton` #2839