Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added internal NonSubscriptionTransaction.storeTransactionIdentifier #3009

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Added internal NonSubscriptionTransaction.storeTransactionIdentifier #3009

merged 1 commit into from
Aug 14, 2023

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented Aug 14, 2023 •
edited
Loading

This will be used for #2841.

@NachoSoto NachoSoto added the feat A new feature label Aug 14, 2023
@NachoSoto NachoSoto requested a review from a team August 14, 2023 16:30
@NachoSoto NachoSoto mentioned this pull request Aug 14, 2023
Merged
@NachoSoto NachoSoto force-pushed the non-sub-transaction-store-identifier branch 4 times, most recently from 6f4a089 to bbc9e82 Compare August 14, 2023 16:36
aboedo
aboedo reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@aboedo aboedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, but I'd maybe keep it as internal until we have a clear reason to expose it as public

Sources/Purchasing/NonSubscriptionTransaction.swift Outdated
Comment on lines 29 to 30
/// The unique identifier for the transaction created by the Store.
@objc public let storeTransactionIdentifier: String
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make it internal for now, because:
a) we don't currently expose it for subscriptions, so maybe it's better to avoid confusion
b) it's also not exposed on android, so maybe it's better for parity?
c) we're doing related work with external purchases API, we should ensure that we unify naming before exposing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Will do.

@NachoSoto NachoSoto added refactor A code change that neither fixes a bug nor adds a feature and removed feat A new feature labels Aug 14, 2023
@NachoSoto NachoSoto marked this pull request as draft August 14, 2023 21:56
@NachoSoto NachoSoto force-pushed the non-sub-transaction-store-identifier branch from bbc9e82 to ceb5393 Compare August 14, 2023 22:30
@NachoSoto NachoSoto changed the title Expose new NonSubscriptionTransaction.storeTransactionIdentifier Added internal NonSubscriptionTransaction.storeTransactionIdentifier Aug 14, 2023
@NachoSoto NachoSoto requested a review from aboedo August 14, 2023 22:31
@NachoSoto NachoSoto marked this pull request as ready for review August 14, 2023 22:31
@NachoSoto
Expose new NonSubscriptionTransaction.storeTransactionIdentifier
fdd12d4 
This will be used for #2841, but it can be useful for users as well.
@NachoSoto NachoSoto force-pushed the non-sub-transaction-store-identifier branch from ceb5393 to fdd12d4 Compare August 14, 2023 22:32
@NachoSoto NachoSoto enabled auto-merge (squash) August 14, 2023 22:41
@NachoSoto NachoSoto merged commit 022cdea into main Aug 14, 2023
13 of 14 checks passed
@NachoSoto NachoSoto deleted the non-sub-transaction-store-identifier branch August 14, 2023 23:13
This was referenced Aug 16, 2023
Closed
Merged
NachoSoto pushed a commit that referenced this pull request Aug 17, 2023
@RCGitBot
[AUTOMATIC] Release/4.25.5 (#3033)
7629e2a 
**This is an automatic release.**

### Bugfixes
* `PurchasesOrchestrator`: fixed callback not invoked regression during
downgrades (#3028) via NachoSoto (@NachoSoto)
* `TransactionPoster`: don't finish transactions for non-subscriptions
if they're not processed (#2841) via NachoSoto (@NachoSoto)
### Performance Improvements
* `StoreKit 2`: only listen to `StoreKit.Transaction.updates` when SK2
is enabled (#3032) via NachoSoto (@NachoSoto)
* `CustomerInfoManager`: post transactions in parallel to POST receipts
only once (#2954) via NachoSoto (@NachoSoto)
### Other Changes
* `PostedTransactionCache`: remove implementation (#3030) via NachoSoto
(@NachoSoto)
* `Integration Tests`: improved `testCanPurchaseMultipleSubscriptions`
(#3025) via NachoSoto (@NachoSoto)
* `GitHub`: improved `ISSUE_TEMPLATE` (#3022) via NachoSoto (@NachoSoto)
* `TransactionPoster`: added transaction ID and Date to log (#3026) via
NachoSoto (@NachoSoto)
* `TransactionPoster`: fix iOS 12 test (#3018) via NachoSoto
(@NachoSoto)
* `SystemInfo`: added `ClockType` (#3014) via NachoSoto (@NachoSoto)
* `Integration Tests`: begin tests with
`UIApplication.willEnterForegroundNotification` to simulate a real app
(#3015) via NachoSoto (@NachoSoto)
* `Integration Tests`: add tests to verify `CustomerInfo`+`Offerings`
request de-dupping (#3013) via NachoSoto (@NachoSoto)
* `SwiftLint`: disable `unneeded_synthesized_initializer` (#3010) via
NachoSoto (@NachoSoto)
* Added `internal`
`NonSubscriptionTransaction.storeTransactionIdentifier` (#3009) via
NachoSoto (@NachoSoto)
* `Integration Tests`: added tests for non-renewing and non-consumable
packages (#3008) via NachoSoto (@NachoSoto)
* Expanded `EnsureNonEmptyArrayDecodable` to
`EnsureNonEmptyCollectionDecodable` (#3002) via NachoSoto (@NachoSoto)
MarkVillacampa pushed a commit that referenced this pull request Sep 6, 2023
@NachoSoto @MarkVillacampa
Added internal `NonSubscriptionTransaction.storeTransactionIdentifi…
534107a 
…er` (#3009)

This will be used for #2841.
MarkVillacampa pushed a commit that referenced this pull request Sep 6, 2023
@RCGitBot @MarkVillacampa
[AUTOMATIC] Release/4.25.5 (#3033)
d08f35d 
**This is an automatic release.**

### Bugfixes
* `PurchasesOrchestrator`: fixed callback not invoked regression during
downgrades (#3028) via NachoSoto (@NachoSoto)
* `TransactionPoster`: don't finish transactions for non-subscriptions
if they're not processed (#2841) via NachoSoto (@NachoSoto)
### Performance Improvements
* `StoreKit 2`: only listen to `StoreKit.Transaction.updates` when SK2
is enabled (#3032) via NachoSoto (@NachoSoto)
* `CustomerInfoManager`: post transactions in parallel to POST receipts
only once (#2954) via NachoSoto (@NachoSoto)
### Other Changes
* `PostedTransactionCache`: remove implementation (#3030) via NachoSoto
(@NachoSoto)
* `Integration Tests`: improved `testCanPurchaseMultipleSubscriptions`
(#3025) via NachoSoto (@NachoSoto)
* `GitHub`: improved `ISSUE_TEMPLATE` (#3022) via NachoSoto (@NachoSoto)
* `TransactionPoster`: added transaction ID and Date to log (#3026) via
NachoSoto (@NachoSoto)
* `TransactionPoster`: fix iOS 12 test (#3018) via NachoSoto
(@NachoSoto)
* `SystemInfo`: added `ClockType` (#3014) via NachoSoto (@NachoSoto)
* `Integration Tests`: begin tests with
`UIApplication.willEnterForegroundNotification` to simulate a real app
(#3015) via NachoSoto (@NachoSoto)
* `Integration Tests`: add tests to verify `CustomerInfo`+`Offerings`
request de-dupping (#3013) via NachoSoto (@NachoSoto)
* `SwiftLint`: disable `unneeded_synthesized_initializer` (#3010) via
NachoSoto (@NachoSoto)
* Added `internal`
`NonSubscriptionTransaction.storeTransactionIdentifier` (#3009) via
NachoSoto (@NachoSoto)
* `Integration Tests`: added tests for non-renewing and non-consumable
packages (#3008) via NachoSoto (@NachoSoto)
* Expanded `EnsureNonEmptyArrayDecodable` to
`EnsureNonEmptyCollectionDecodable` (#3002) via NachoSoto (@NachoSoto)
NachoSoto added a commit that referenced this pull request Feb 6, 2024
@NachoSoto
NonSubscriptionTransaction: expose storeTransactionIdentifier
897b5a3 
Fixes #3636.

This was added in #3009.
It was not made `public` because it was only used for #2841, but as explained in #3636 it can be useful as `public`.
@NachoSoto NachoSoto mentioned this pull request Feb 6, 2024
Merged
NachoSoto added a commit that referenced this pull request Feb 6, 2024
@NachoSoto
NonSubscriptionTransaction: expose storeTransactionIdentifier (#3639
51fd49e 
)

Fixes #3636.

This was added in #3009.
It was not made `public` because it was only used for #2841, but as
explained in #3636 it can be useful as `public`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboedo aboedo aboedo approved these changes

Assignees
No one assigned
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NachoSoto @aboedo