Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomerInfo: add VerificationResult to description #3081

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

NachoSoto
Copy link
Contributor

I needed this to debug a test failure, so it can be useful.

@NachoSoto NachoSoto added the refactor A code change that neither fixes a bug nor adds a feature label Aug 24, 2023
@NachoSoto NachoSoto requested a review from a team August 24, 2023 18:26
I needed this to debug a test failure, so it can be useful.
@NachoSoto NachoSoto force-pushed the customer-info-description-verification-result branch from 0d877f9 to 78e7f64 Compare August 24, 2023 22:31
let verificationResult: String

if #available(iOS 13.0, macOS 10.15, tvOS 13.0, watchOS 6.2, *) {
verificationResult = self.entitlements.verification.debugDescription
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I guess verificationResult is not technically part of the customerInfo but of EntitlementInfos... But I guess it's also related 1-1 currently, so I'm ok adding it to the description.

@NachoSoto NachoSoto enabled auto-merge (squash) August 25, 2023 14:44
@NachoSoto NachoSoto merged commit 247dc1a into main Aug 25, 2023
15 checks passed
@NachoSoto NachoSoto deleted the customer-info-description-verification-result branch August 25, 2023 16:13
NachoSoto pushed a commit that referenced this pull request Aug 28, 2023
**This is an automatic release.**

### Dependency Updates
* Bump fastlane-plugin-revenuecat_internal from `b2108fb` to `a297205`
(#3106) via dependabot[bot] (@dependabot[bot])
* Bump activesupport from 7.0.4.3 to 7.0.7.2 in
/Tests/InstallationTests/CocoapodsInstallation (#3071) via
dependabot[bot] (@dependabot[bot])
* Bump activesupport from 7.0.4.3 to 7.0.7.2 (#3070) via dependabot[bot]
(@dependabot[bot])
### Other Changes
* `Integration Tests`: fixed another flaky test (#3111) via NachoSoto
(@NachoSoto)
* `CustomEntitlementComputation`: enable `restorePurchases` in public
API (#3090) via NachoSoto (@NachoSoto)
* `CustomerInfo`: add `VerificationResult` to `description` (#3081) via
NachoSoto (@NachoSoto)
* `Integration Tests`: fixed race condition in flaky test (#3086) via
NachoSoto (@NachoSoto)
MarkVillacampa pushed a commit that referenced this pull request Sep 6, 2023
**This is an automatic release.**

### Dependency Updates
* Bump fastlane-plugin-revenuecat_internal from `b2108fb` to `a297205`
(#3106) via dependabot[bot] (@dependabot[bot])
* Bump activesupport from 7.0.4.3 to 7.0.7.2 in
/Tests/InstallationTests/CocoapodsInstallation (#3071) via
dependabot[bot] (@dependabot[bot])
* Bump activesupport from 7.0.4.3 to 7.0.7.2 (#3070) via dependabot[bot]
(@dependabot[bot])
### Other Changes
* `Integration Tests`: fixed another flaky test (#3111) via NachoSoto
(@NachoSoto)
* `CustomEntitlementComputation`: enable `restorePurchases` in public
API (#3090) via NachoSoto (@NachoSoto)
* `CustomerInfo`: add `VerificationResult` to `description` (#3081) via
NachoSoto (@NachoSoto)
* `Integration Tests`: fixed race condition in flaky test (#3086) via
NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants