Add diagnosticsQueue to BackendConfiguration #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegaro
added
refactor
tonidero
approved these changes
Apr 10, 2024
Sources/Networking/Backend.swift
Outdated
| @@ -174,6 +175,14 @@ extension Backend { | |||
| return operationQueue | |||
| } | |||
|
|
|||
| static func createDiagnosticsQueue() -> OperationQueue { | |||
| let operationQueue = OperationQueue() | |||
| operationQueue.name = "Diagnostics Queue" | |||
There was a problem hiding this comment.
Should we name it RC Diagnostics queue? So people know it's from RevenueCat.
There was a problem hiding this comment.
the other queue doesn't have RC either, adding it
| /// Adds the `operation` to the diagnostics `OperationQueue` potentially adding a random delay. | ||
| func addDiagnosticsOperation( | ||
| _ operation: NetworkOperation, | ||
| delay: Delay |
There was a problem hiding this comment.
FFTI. Should this have a default value for Delay? I guess it doesn't really matter, depending on how we use it.
There was a problem hiding this comment.
I think that makes sense, I will add a Long
This was referenced Apr 10, 2024
tonidero
pushed a commit
that referenced
this pull request
Apr 12, 2024
**This is an automatic release.** ### Bugfixes * Prevent Template 4 from wrapping Lifetime (#3789) via Josh Holtz (@joshdholtz) * Add enum entry for external purchases store (#3779) via Mark Villacampa (@MarkVillacampa) ### Dependency Updates * Bump fastlane from 2.219.0 to 2.220.0 (#3783) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Add option to intercept touch events in `PaywallViewController` (#3801) via Toni Rico (@tonidero) * Create DiagnosticsPostOperation (#3795) via Cesar de la Vega (@vegaro) * Add diagnosticsQueue to BackendConfiguration (#3794) via Cesar de la Vega (@vegaro) * Add origin to HTTPResponseType (#3793) via Cesar de la Vega (@vegaro) * Add name property to HTTPRequestPath (#3790) via Cesar de la Vega (@vegaro) * Add name to VerificationResult (#3792) via Cesar de la Vega (@vegaro) * Add HTTPRequest.DiagnosticsPath (#3791) via Cesar de la Vega (@vegaro) * Add async `syncAttributesAndOfferingsIfNeeded()` (#3785) via Josh Holtz (@joshdholtz) * iOS append events to JSONL file and get diagnostics events (#3781) via Cesar de la Vega (@vegaro) * Fix offerings integration test (#3782) via Josh Holtz (@joshdholtz)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a different OperationQueue to be used when sending Diagnostics