Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add STFT function to Function class #620

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

AdvaitChandorkar07
Copy link

@AdvaitChandorkar07 AdvaitChandorkar07 commented Jun 12, 2024

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Lint (black rocketpy/ tests/) has passed locally

Current behavior

STFT feature was requested in issue #308 with link to #292 as example

New behavior

Added STFT

@AdvaitChandorkar07 AdvaitChandorkar07 requested a review from a team as a code owner June 12, 2024 18:31
@Gui-FernandesBR Gui-FernandesBR changed the base branch from master to develop June 12, 2024 19:41
@Gui-FernandesBR Gui-FernandesBR added the Enhancement New feature or request, including adjustments in current codes label Jun 12, 2024
@Gui-FernandesBR Gui-FernandesBR changed the title Add STFT function to Function class ENH: Add STFT function to Function class Jun 12, 2024
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Jun 12, 2024
@Gui-FernandesBR Gui-FernandesBR linked an issue Jun 12, 2024 that may be closed by this pull request
@Gui-FernandesBR
Copy link
Member

@AdvaitChandorkar07 thank you so much for your contribution! We are going to review your PR as soon as possible.

At a first glance, I think it solves the problem as requested by #308 . Good job!

@Gui-FernandesBR Gui-FernandesBR force-pushed the feature/stft-function branch 3 times, most recently from 51e83b5 to 824b157 Compare June 29, 2024 22:15
@Gui-FernandesBR Gui-FernandesBR force-pushed the feature/stft-function branch 2 times, most recently from c442493 to 408403c Compare July 6, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request, including adjustments in current codes
Projects
Status: Next Version
Development

Successfully merging this pull request may close these issues.

ENH: Implement time-frequency analysis methods
2 participants