Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the error message when connection fails #1539

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

costin-zaharia-sonarsource
Copy link
Member

@costin-zaharia-sonarsource costin-zaharia-sonarsource commented Mar 24, 2023

Fixes #1149 (part of)

This takes care of the error message when a connection to the server cannot be established.

@costin-zaharia-sonarsource costin-zaharia-sonarsource force-pushed the costin/improve-connection-failed-message branch 2 times, most recently from f190189 to 7b148a5 Compare March 24, 2023 17:00
@costin-zaharia-sonarsource costin-zaharia-sonarsource removed this from In progress in S4NET Kanban Mar 24, 2023
@costin-zaharia-sonarsource costin-zaharia-sonarsource force-pushed the costin/improve-connection-failed-message branch from 7b148a5 to d82bb34 Compare March 27, 2023 08:14
@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sebastien-marichal sebastien-marichal merged commit 5ba6266 into master Mar 28, 2023
@sebastien-marichal sebastien-marichal deleted the costin/improve-connection-failed-message branch March 28, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide more user friendly error when SQ is down or not running
2 participants