Add specific error message when organization is missing for SonarCloud #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costin-zaharia-sonarsource
force-pushed
the
costin/1149
branch
from
92f3b03
to
653193f
Compare
sebastien-marichal
requested changes
Mar 30, 2023
| @@ -41,7 +41,7 @@ public SonarQubeWebServer(IDownloader downloader, Version serverVersion, ILogger | |||
| } | |||
| } | |||
|
|
|||
| public override async Task<bool> IsServerLicenseValid() | |||
| public override async Task<bool> IsServerLicenseValid(string serverUrl) | |||
There was a problem hiding this comment.
It is bizarre to have a parameter here only to be able to log as it could be different from the one used to make the request.
I'd rather have the IDownloader.GetBaseUri back and use it to log. That way, we ensure the right serverUrl from the HttpClient.
WDYT?
There was a problem hiding this comment.
I agree. This simplifies the commit a bit.
costin-zaharia-sonarsource
force-pushed
the
costin/1149
branch
from
636fa5b
to
3a2cfec
Compare
|
Kudos, SonarCloud Quality Gate passed! |
sebastien-marichal
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1149