Fail hard when C# and VB.NET plugins are missing on the server #1787
Conversation
| // Arrange | ||
| var localCacheDir = TestUtils.CreateTestSpecificFolderWithSubPaths(TestContext); | ||
| var logger = new TestLogger(); | ||
|
|
||
| var request1 = new Plugin("no.matching.resource.plugin", "2.0", "non.existent.resource.zip"); |
There was a problem hiding this comment.
Removed: no matching plugin is causing hard failure (already tested in EmbeddedInstall_MissingResource_ThrowFileNotFoundException).
| @@ -95,6 +80,7 @@ public void EmbeddedInstall_SinglePlugin_SingleResource_Succeeds() | |||
| var actualFiles = testSubject.InstallAssemblies(new Plugin[] { requestedPlugin }); | |||
|
|
|||
| // Assert | |||
| logger.AssertInfoLogged("Processing plugin: plugin1 version 1.0"); | |||
There was a problem hiding this comment.
Assertion moved from InstallAssemblies_ValidPlugins_PluginsVersionLogInfo.
The previous test was not feasible anymore due to the introduction of the new exception being thrown when plugins are missing.
There was a problem hiding this comment.
LGTM
There is a Code Smell failing the Quality Gate, that needs attention.
| { | ||
| const string missingPluginKey = "missingPlugin"; | ||
| const string missingPluginVersion = "1.0"; | ||
| const string missingPluginResource = "resource.txt"; |
There was a problem hiding this comment.
Personal opinion: I liked could.be.anything. It conveys the information that the name of the plugin resource is not relevant for the test... and could be anything!
|
Kudos, SonarCloud Quality Gate passed! |
As discussed offline, the Code Smell mentioned above (new link here) has been solved as "Won't fix" with the following reasoning:
@cristian-ambrosini-sonarsource CI can be re-run. |
cristian-ambrosini-sonarsource
deleted the
cristian/fail-hard-missing-plugin
branch
Fixes #1475