Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for potential XSS attacks and formatting issues #1005

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Fix for potential XSS attacks and formatting issues #1005

merged 1 commit into from
Jan 2, 2023

Conversation

FireMasterK
Copy link
Member

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

@FireMasterK FireMasterK changed the title Fix for potential XSS attacks Fix for potential XSS attacks and formatting issues Dec 30, 2022
@FireMasterK FireMasterK added the youtube service, https://www.youtube.com/ label Dec 30, 2022
AudricV
AudricV reviewed Dec 30, 2022
View reviewed changes
Copy link
Member

@AudricV AudricV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert the imports move please? Otherwise, changes LGTM.

@FireMasterK
Copy link
Member Author

Could you revert the imports move please? Otherwise, changes LGTM.

Why? They were changed by the auto formatter?

@AudricV
Copy link
Member

AudricV commented Dec 31, 2022

Yes, we should only see an import addition and not import moves at the top of the file.

@Stypox Stypox merged commit 991394b into TeamNewPipe:dev Jan 2, 2023
@FireMasterK FireMasterK deleted the fix-escaping-xss branch January 2, 2023 16:55
@FireMasterK FireMasterK mentioned this pull request Jan 4, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

@AudricV AudricV AudricV approved these changes

Assignees
No one assigned
Labels
youtube service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FireMasterK @AudricV @Stypox