[SoundCloud] Fix extraction of tracks like count #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoundCloud is using likes_count to return the like count of a track, like it was the case before they switched to favoritings_count.
…tractorTest test classes As like count is now returned by the extractor, we need to assert a positive minimum like count, which is close to the actual value, in order to avoid test failures due to lower like counts than the ones excepted.
Stypox
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the extraction of SoundCloud likes. It uses the current property to get like counts and not the previous one (see #1017).
The corresponding stream like count tests have been updated to assert a value close to the real one.
Fixes #1017.