Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bandcamp] Show comments as disabled on radio streams #1031

Merged
merged 1 commit into from
Feb 27, 2023
Merged

[Bandcamp] Show comments as disabled on radio streams #1031

merged 1 commit into from
Feb 27, 2023

Conversation

petlyh
Copy link
Contributor

@petlyh petlyh commented Feb 23, 2023

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.
    No NewPipe changes required.

Comments are now shown as disabled on Bandcamp radio streams, which do not have comments.

Fixes TeamNewPipe/NewPipe#9732

Before After
image image

@AudricV AudricV added bug bandcamp service, https://bandcamp.com labels Feb 23, 2023
Stypox
Stypox approved these changes Feb 26, 2023
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, but I have no knowledge of Bandcamp

fynngodau
fynngodau approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@fynngodau fynngodau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an amazing change, thanks a lot for opening the PR!

@fynngodau fynngodau merged commit 3fdb6ee into TeamNewPipe:dev Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fynngodau fynngodau fynngodau approved these changes

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
bandcamp service, https://bandcamp.com bug
Projects
No open projects
v0.25.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bandcamp -> Radio shows a "Sorry, something went wrong" error
4 participants
@petlyh @fynngodau @Stypox @AudricV