Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hasCreatorReply() to CommentsInfoItem #1111

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Add hasCreatorReply() to CommentsInfoItem #1111

merged 3 commits into from
Oct 9, 2023

Conversation

FineFindus
Copy link
Contributor

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Adds support for checking if the video creator has replied to a comment.

Currently, the following tests fail, I think this is unrelated to the changed code, if not please let me know.

  • YoutubeChannelExtractorTest$CarouselHeader. testBanners()
  • YoutubeChannelExtractorTest$InteractiveTabbedHeader. testDescription()
  • YoutubeCommentsExtractorTest$FormattingTest. testGetCommentsFormatting()

@TobiGr TobiGr added enhancement youtube service, https://www.youtube.com/ labels Sep 25, 2023
TobiGr
TobiGr approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I also added support for PeerTube.

@TobiGr TobiGr added the peertube service label Oct 9, 2023
@TobiGr
Copy link
Member

TobiGr commented Oct 9, 2023

mocks need to be generated for the new test

@TobiGr TobiGr changed the title feat(youtube/comments): support creator replies Add hasCreatorReply() to CommentsInfoItem Oct 9, 2023
@TobiGr TobiGr merged commit d6f5cba into TeamNewPipe:dev Oct 9, 2023
4 checks passed
@FineFindus FineFindus deleted the feat/creator-reply branch October 9, 2023 14:29
@FineFindus FineFindus mentioned this pull request Oct 9, 2023
Merged
@AudricV AudricV mentioned this pull request Oct 16, 2023
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
enhancement peertube service youtube service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FineFindus @TobiGr