[YouTube] Implement emergency meta info #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
1 task
YouTube provides that meta info panel when users search for really sensitive content like suicide (e.g. "blue whale"). It contains: - an encouragement as title (e.g. "We are with you") - a phone number as action - details about how to call the phone number (e.g. availability) - an url pointing to the website of an association Also add a test that just checks if a meta info is properly extracted
YoutubeParsingHelper was longer than 2000 lines which caused checkstyle issues
Stypox
force-pushed
the
yt-emergency-info
branch
from
42d2771
to
5b59a1a
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in #1127, YouTube provides that meta info panel when users search for really sensitive content like suicide (e.g. "blue whale").
It contains:
Since NewPipe's meta infos contain only one details field, I concatenated the phone number on a new line after the phone number details.
This is how it looks in NewPipe:
Also add a test that just checks if a meta info is properly extracted. Since this test depends on #1127, this PR includes those commits, too. I will cherry-pick once #1127 is merged.
Also move meta info extraction to separate file, since YoutubeParsingHelper was longer than 2000 lines which caused checkstyle issues.