Cleanup of YoutubeStreamExtractor and some related classes
#782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
requested changes
Feb 16, 2022
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Outdated
Show resolved
Hide resolved
litetex
force-pushed
the
cleanup-yt-stream-extractor
branch
from
377c64b
to
58c1297
Compare
Stypox
requested changes
Mar 19, 2022
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Outdated
Show resolved
Hide resolved
litetex
force-pushed
the
cleanup-yt-stream-extractor
branch
2 times, most recently
from
e1f8926
to
97e3e0f
Compare
Stypox
approved these changes
Apr 30, 2022
| continue; | ||
| } | ||
|
|
||
| try { |
There was a problem hiding this comment.
I guess the only reason you didn't convert this into streams is because there is exception handling inside it ;-)
There was a problem hiding this comment.
Correct, Parsing exception is not unchecked
* Fixed obvious sonar(lint) warnings * Abstracted some code (get*Streams) * Used some new lines to make code better readable * Chopped down brace-jungle in some methods * Use StandardCharset (Java 8 4tw)
litetex
force-pushed
the
cleanup-yt-stream-extractor
branch
from
97e3e0f
to
fe30eb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code cleanup - Summary what I did:
I have tested the API against NewPipe. - No but tests work fineI agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.- No changes required for NewPipe