Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use immutable sets in YoutubeParsingHelper and bump required Java version to 11. #893

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Use immutable sets in YoutubeParsingHelper and bump required Java version to 11. #893

merged 1 commit into from
Nov 9, 2022

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Aug 13, 2022 •
edited
Loading

  • Bump the required Java version to 11.
  • Use the immutable Set factory methods in YoutubeParsingHelper.

AudricV
AudricV reviewed Aug 13, 2022
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@Isira-Seneviratne Isira-Seneviratne force-pushed the Static_sets branch 3 times, most recently from 75bbde1 to 88bfc8c Compare August 24, 2022 01:31
FireMasterK
FireMasterK approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@FireMasterK FireMasterK left a comment •
edited by Isira-Seneviratne
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, any particular reason why we're using Locale.ROOT and not Locale.US or Locale.ENGLISH? Since these are URLs, I don't think it matters much, does it?

@Isira-Seneviratne
Copy link
Member Author

Isira-Seneviratne commented Nov 7, 2022 •
edited
Loading

Looks mostly good, any particular reason why we're using Locale.ROOT and not Locale.US or Locale.ENGLISH? Since these are URLs, I don't think it matters much, does it?

I used the suggestions provided in Android Studio.

Also, I accidentally edited your comment while replying, sorry about that.

@Isira-Seneviratne Isira-Seneviratne merged commit 1be2707 into TeamNewPipe:dev Nov 9, 2022
@AudricV AudricV changed the title Use immutable sets in YoutubeParsingHelper. Use immutable sets in YoutubeParsingHelper and bump required Java version to 11. Nov 9, 2022
@Isira-Seneviratne Isira-Seneviratne deleted the Static_sets branch November 12, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opusforlife2 opusforlife2 opusforlife2 left review comments

@AudricV AudricV AudricV left review comments

@FireMasterK FireMasterK FireMasterK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Isira-Seneviratne @FireMasterK @opusforlife2 @AudricV