Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PeerTube] Support comment replies #941

Merged
merged 1 commit into from
Dec 31, 2022
Merged

[PeerTube] Support comment replies #941

merged 1 commit into from
Dec 31, 2022

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Oct 9, 2022 •
edited
Loading

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Based on / Requires #936
Related TeamNewPipe/NewPipe#9020 + TeamNewPipe/NewPipe#9410

Implement getReplyCount() and getReplies() for PeerTube.

@TobiGr TobiGr force-pushed the feat/peertube-comment-replies branch 4 times, most recently from 70748e7 to 1894115 Compare October 9, 2022 22:03
@Stypox Stypox mentioned this pull request Oct 31, 2022
Open
34 tasks
@AudricV
Copy link
Member

AudricV commented Nov 27, 2022

Could you rebase this PR, please? Thanks in advance!

@TobiGr TobiGr force-pushed the feat/peertube-comment-replies branch 2 times, most recently from b77d8fc to 2f02913 Compare November 28, 2022 13:38
@TobiGr TobiGr force-pushed the feat/peertube-comment-replies branch from 2f02913 to 4e66b22 Compare December 1, 2022 13:05
AudricV
AudricV approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@AudricV AudricV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Stypox Could you take a look at this PR too and merge it if it looks good to you? Thanks in advance!

@TobiGr TobiGr mentioned this pull request Dec 3, 2022
Draft
7 tasks
@Stypox Stypox merged commit 7b54457 into dev Dec 31, 2022
@opusforlife2 opusforlife2 deleted the feat/peertube-comment-replies branch December 31, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

@AudricV AudricV AudricV approved these changes

Assignees
No one assigned
Labels
enhancement peertube service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TobiGr @AudricV @Stypox